Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ScriptHookVDotNetCore #101

Merged
merged 6 commits into from
Oct 25, 2023

Conversation

Sardelka9515
Copy link
Contributor

@Sardelka9515 Sardelka9515 commented Feb 9, 2023

Nothing need to be changed since it shares identical scripting API with SHVDN.

Works perfectly, at least in my testing

@justalemon justalemon self-assigned this Feb 9, 2023
@justalemon justalemon added priority: p3 low A cosmetic bug or a new feature request type: feature request Request to implement a specific feature status: acknowledged We are aware of the bug or feature request labels Feb 9, 2023
@justalemon
Copy link
Member

GitHub is being stupid and is not allowing me to update the branch.

Please merge master onto the PR so it can actually try and build with .NET 7 on CI

@justalemon
Copy link
Member

Turns out, I forgot to change the build .NET version. Whops.

Can you merge master again? Thanks!

@Sardelka9515
Copy link
Contributor Author

No problem

@justalemon
Copy link
Member

Looks like it copies the SHVDNCore DLL to the output directory. Could you please change that?

You could take a look at the SHVDN3 csproj if you are not sure how to do it :)

image

@justalemon
Copy link
Member

Also, I don't think that the deps.json is required. That can be disabled with:

<GenerateDependencyFile>false</GenerateDependencyFile>

@Sardelka9515
Copy link
Contributor Author

Done. Do i need to squash this to one commit?

@justalemon
Copy link
Member

Sure

@justalemon
Copy link
Member

Just letting you know: There is nothing wrong with this PR, I just want to do some stuff before I merge and release :)

@Sardelka9515
Copy link
Contributor Author

Sure, no porblem 🙆‍♂️

@Sardelka9515
Copy link
Contributor Author

Closing this to avoid confusion as SHVDNC might get merged into SHVDN itself in the future

@justalemon
Copy link
Member

I have been following the issues on the SHVDN repo.

Can you keep this around while .NET Core support is fully implemented? So i can do some testing locally and prepare for the Core version.

@Sardelka9515 Sardelka9515 reopened this Mar 3, 2023
@justalemon
Copy link
Member

So, it was decided in scripthookvdotnet/scripthookvdotnet#1036 that Core/5+ support will not be added to the existing version of SHVDN.

@Sardelka9515 do you plan to keep working on the core version in your repo?

@Sardelka9515
Copy link
Contributor Author

Sardelka9515 commented Jun 23, 2023

The core version can be maintained with minimum efforts (I can easily merge the the SHVDN upstream code at anytime) it currently have some issues with exception handling when running alongside SHVDN. it was resolved in scripthookvdotnet#1167 but the new version is not released yet. Maybe kagikn will make another version for .NET Core in the future but SHVDNC should work fine for now

I'm currently not very active in GTAV modding, so feel free to close this if you want.

@justalemon justalemon added this to the 2.0 milestone Oct 25, 2023
@justalemon justalemon merged commit 3f36b63 into LemonUIbyLemon:master Oct 25, 2023
5 checks passed
@justalemon justalemon removed the status: acknowledged We are aware of the bug or feature request label Oct 25, 2023
@justalemon justalemon added the status: completed The feature has been completed of the bug has been patched label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 low A cosmetic bug or a new feature request status: completed The feature has been completed of the bug has been patched type: feature request Request to implement a specific feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants