Adding post_id and type_ filters to combined reports. #5348
+116
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added tests for these also. - Some additional cleanup of the joins in reports_combined. - Fixes #5265
dessalines
requested review from
Nutomic,
phiresky,
dullbananas and
SleeplessOne1917
as code owners
Nutomic
reviewed
Jan 24, 2025
| PrivateMessages, | ||
| Communities, | ||
| } | ||
|
|
There was a problem hiding this comment.
Move this into crates/db_views/src/report_combined_view.rs as thats where its used.
There was a problem hiding this comment.
All these search and sort enums, that are used in api common, schema, views are here. I'd rather keep them in one place, rather than spread them out into different crates and files.
Nutomic
reviewed
Jan 24, 2025
| .eq(community::id) | ||
| .or(post::community_id.eq(community::id)), | ||
| ); | ||
|
|
There was a problem hiding this comment.
You can move these into a helper function and reuse them for get_report_count() too.
There was a problem hiding this comment.
I'd like to do this for every DB view, but diesel's return types make it near impossible to externalize joins or filters into functions.
dullbananas
approved these changes
Jan 26, 2025
Nutomic
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
post_idfield inListCommentReportsRequest#5265