Adding combined inbox #5257
Draft
Adding combined inbox #5257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add pagination cursor * store timestamp instead of id in cursor (partial) * Revert "store timestamp instead of id in cursor (partial)" This reverts commit 89359dd. * use paginated query builder
…into combined_tables_2
…into combined_tables_2
Co-authored-by: dullbananas <[email protected]>
Co-authored-by: dullbananas <[email protected]>
Nutomic
reviewed
Dec 12, 2024
|
|
||
| Ok(Json(PersonCommentMentionResponse { | ||
| person_comment_mention_view, | ||
| })) |
There was a problem hiding this comment.
How about changing the return values of mark as read to simply SuccessResponse? Then it would also make sense to switch to a single mark_as_read endpoint so clients dont have to differentiate between comment, post, etc.
There was a problem hiding this comment.
On updates and creates, its really helpful to get back the changed / new item. Then the front end can replace that object after a success, and make the findAndReplace function generic, instead of having a bunch of specific ones for each action, where the response tells you nothing about what changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #2444