Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failures #2263

Merged
merged 2 commits into from
May 17, 2022
Merged

Fix CI failures #2263

merged 2 commits into from
May 17, 2022

Conversation

Nutomic
Copy link
Member

@Nutomic Nutomic commented May 16, 2022

I noticed that CI was failing on main with the following error:

+ git fetch --tags
fatal: unsafe repository ('/drone/src' is owned by someone else)

To add an exception for this directory, call:
	git config --global --add safe.directory /drone/src

Because there is a new git security feature, which complains about incorrect permissions on the ci working directory. Moving the chown command was enough to fix that.

After that, there were some more weird errors which seem to be caused by clux/muslrust:1.60.0 being broken (clux/muslrust#94). For now i downgraded to 1.59.0 which fixes it.

@Nutomic Nutomic requested a review from dessalines as a code owner May 16, 2022 11:50
@Nutomic Nutomic force-pushed the fix-ci-unsafe-repo branch from 179b276 to 26d5b38 Compare May 16, 2022 11:50
@Nutomic Nutomic changed the title test Fix CI failures May 16, 2022
@Nutomic
Copy link
Member Author

Nutomic commented May 16, 2022

Also youtube metadata fetching broke...

@dessalines
Copy link
Member

I'm testing youtube metadata fetching locally rn.

@dessalines
Copy link
Member

Okay I found the cause of the youtube failure: it has to do with the user agent not using https, they reject all non-https designated requests.

I'd just comment or remove that test then for now, because they still do accept the lemmy user agent overall.

@Nutomic
Copy link
Member Author

Nutomic commented May 17, 2022

What do you mean with "user agent not using https"? The youtube url has https as protocol.

@dessalines
Copy link
Member

Our lemmy user agent uses our own server info:

https://github.com/LemmyNet/lemmy/blob/main/crates/api_common/src/request.rs#L220

@Nutomic
Copy link
Member Author

Nutomic commented May 17, 2022

Okay, removed the youtube test so that we can get ci working again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants