-
-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI failures #2263
Fix CI failures #2263
Conversation
179b276
to
26d5b38
Compare
Also youtube metadata fetching broke... |
I'm testing youtube metadata fetching locally rn. |
Okay I found the cause of the youtube failure: it has to do with the user agent not using https, they reject all non-https designated requests. I'd just comment or remove that test then for now, because they still do accept the lemmy user agent overall. |
What do you mean with "user agent not using https"? The youtube url has https as protocol. |
Our lemmy user agent uses our own server info: https://github.com/LemmyNet/lemmy/blob/main/crates/api_common/src/request.rs#L220 |
Okay, removed the youtube test so that we can get ci working again. |
I noticed that CI was failing on main with the following error:
Because there is a new git security feature, which complains about incorrect permissions on the ci working directory. Moving the chown command was enough to fix that.
After that, there were some more weird errors which seem to be caused by clux/muslrust:1.60.0 being broken (clux/muslrust#94). For now i downgraded to 1.59.0 which fixes it.