Add local search history to the community list screen #871

wkoomson · 2023-06-24T16:25:18Z

This change adds a search history Dao/Repository/ViewModel so that we can save user searches in Room, and display them on the community list screen. Users can click the history item to search it, or click the "X" button to delete it.

This is for issue #811

wkoomson · 2023-06-24T16:56:16Z

Uploaded screen cap of new functionality
https://github.com/dessalines/jerboa/assets/861971/babf157a-ce2b-4402-a9bb-ff483cef7cb9

MV-GH · 2023-06-24T17:13:46Z

Can you add a option to disable saving searches, I can imagine that not everyone wants their searches to be saved.

twizmwazin · 2023-06-24T17:26:23Z

Based on the screen capture, I think searches should be listed in reverse-chronological order. The last thing I searched should be the first item in history.

wkoomson · 2023-06-24T19:18:46Z

Sorted searches in reverse order, added setting to control whether searches are saved or not.

screen cap

screen-20230624-121448.2.mp4

MV-GH · 2023-06-24T19:27:34Z

If you disable the saved searches does it delete the ones it had saved already?

wkoomson · 2023-06-24T21:06:07Z

Updated to clear search history when the option is disabled.

app/src/main/java/com/jerboa/ui/components/community/list/CommunityListActivity.kt

This change adds a search history Dao/Repository/ViewModel so that we can save user searches in Room, and display them on the community list screen. Users can click the history item to search it, or click the "X" button to delete it.

…etting

Also, do not insert search history items when saveSearchHistory is false.

MV-GH

I cant actually run this, causes crash at startup see stacktrace

stack trace

E (1) near "timestamp": syntax error in "CREATE TABLE IF NOT EXISTS SearchHistory( history TEXT PRIMARY KEY NOT NULL timestamp INTEGER NOT NULL )" 2023-06-28 06:01:10.690 6138-6138 SQLiteLog com.jerboa.debug E (1) near "timestamp": syntax error in "CREATE TABLE IF NOT EXISTS SearchHistory( history TEXT PRIMARY KEY NOT NULL timestamp INTEGER NOT NULL )" FATAL EXCEPTION: main Process: com.jerboa.debug, PID: 6138 java.lang.RuntimeException: Unable to start activity ComponentInfo{com.jerboa.debug/com.jerboa.MainActivity}: android.database.sqlite.SQLiteException: near "timestamp": syntax error (code 1 SQLITE_ERROR): , while compiling: CREATE TABLE IF NOT EXISTS SearchHistory( history TEXT PRIMARY KEY NOT NULL timestamp INTEGER NOT NULL ) at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3635) at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3792) at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:103) at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135) at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2210) at android.os.Handler.dispatchMessage(Handler.java:106) at android.os.Looper.loopOnce(Looper.java:201) at android.os.Looper.loop(Looper.java:288) at android.app.ActivityThread.main(ActivityThread.java:7839) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003) Caused by: android.database.sqlite.SQLiteException: near "timestamp": syntax error (code 1 SQLITE_ERROR): , while compiling: CREATE TABLE IF NOT EXISTS SearchHistory( history TEXT PRIMARY KEY NOT NULL timestamp INTEGER NOT NULL ) at android.database.sqlite.SQLiteConnection.nativePrepareStatement(Native Method) at android.database.sqlite.SQLiteConnection.acquirePreparedStatement(SQLiteConnection.java:1047) at android.database.sqlite.SQLiteConnection.prepare(SQLiteConnection.java:654) at android.database.sqlite.SQLiteSession.prepare(SQLiteSession.java:590) at android.database.sqlite.SQLiteProgram.(SQLiteProgram.java:62) at android.database.sqlite.SQLiteStatement.(SQLiteStatement.java:34) at android.database.sqlite.SQLiteDatabase.executeSql(SQLiteDatabase.java:1920) at android.database.sqlite.SQLiteDatabase.execSQL(SQLiteDatabase.java:1842) at androidx.sqlite.db.framework.FrameworkSQLiteDatabase.execSQL(FrameworkSQLiteDatabase.kt:246) at com.jerboa.db.AppDBKt$MIGRATION_17_18$1.migrate(AppDB.kt:527) at androidx.room.RoomOpenHelper.onUpgrade(RoomOpenHelper.kt:91) at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper$OpenHelper.onUpgrade(FrameworkSQLiteOpenHelper.kt:253) at android.database.sqlite.SQLiteOpenHelper.getDatabaseLocked(SQLiteOpenHelper.java:416) at android.database.sqlite.SQLiteOpenHelper.getWritableDatabase(SQLiteOpenHelper.java:316) at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper$OpenHelper.getWritableOrReadableDatabase(FrameworkSQLiteOpenHelper.kt:232) at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper$OpenHelper.innerGetDatabase(FrameworkSQLiteOpenHelper.kt:190) at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper$OpenHelper.getSupportDatabase(FrameworkSQLiteOpenHelper.kt:151) at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper.getWritableDatabase(FrameworkSQLiteOpenHelper.kt:104) at androidx.room.RoomDatabase.inTransaction(RoomDatabase.kt:638) at androidx.room.RoomDatabase.assertNotSuspendingTransaction(RoomDatabase.kt:457) at com.jerboa.db.AccountDao_Impl.getAllSync(AccountDao_Impl.java:289) at com.jerboa.db.AccountRepository.getAllSync(AppDB.kt:227) at com.jerboa.db.AccountViewModel.(AppDB.kt:610) at com.jerboa.db.AccountViewModelFactory.create(AppDB.kt:634) at androidx.lifecycle.ViewModelProvider$Factory.create(ViewModelProvider.kt:83) at androidx.lifecycle.ViewModelProvider.get(ViewModelProvider.kt:187) at androidx.lifecycle.ViewModelProvider.get(ViewModelProvider.kt:153) at androidx.lifecycle.ViewModelLazy.getValue(ViewModelLazy.kt:53) at androidx.lifecycle.ViewModelLazy.getValue(ViewModelLazy.kt:35) at com.jerboa.MainActivity.getAccountViewModel(MainActivity.kt:117) at com.jerboa.MainActivity.onCreate(MainActivity.kt:128) at android.app.Activity.performCreate(Activity.java:8051) at android.app.Activity.performCreate(Activity.java:8031) at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1329) at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3608) ... 12 more

hi

 CREATE TABLE IF NOT EXISTS SearchHistory(
                    history TEXT PRIMARY KEY NOT NULL
                    timestamp INTEGER NOT NULL 
                )

its missing a comma between history and timestamp

app/src/main/java/com/jerboa/ui/components/settings/lookandfeel/LookAndFeelActivity.kt

app/src/main/java/com/jerboa/MainActivity.kt

wkoomson · 2023-06-28T04:54:29Z

I cant actually run this, causes crash at startup see stacktrace
stack trace
E (1) near "timestamp": syntax error in "CREATE TABLE IF NOT EXISTS SearchHistory( history TEXT PRIMARY KEY NOT NULL timestamp INTEGER NOT NULL )" 2023-06-28 06:01:10.690 6138-6138 SQLiteLog com.jerboa.debug E (1) near "timestamp": syntax error in "CREATE TABLE IF NOT EXISTS SearchHistory( history TEXT PRIMARY KEY NOT NULL timestamp INTEGER NOT NULL )" FATAL EXCEPTION: main Process: com.jerboa.debug, PID: 6138 java.lang.RuntimeException: Unable to start activity ComponentInfo{com.jerboa.debug/com.jerboa.MainActivity}: android.database.sqlite.SQLiteException: near "timestamp": syntax error (code 1 SQLITE_ERROR): , while compiling: CREATE TABLE IF NOT EXISTS SearchHistory( history TEXT PRIMARY KEY NOT NULL timestamp INTEGER NOT NULL ) at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3635) at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3792) at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:103) at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135) at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2210) at android.os.Handler.dispatchMessage(Handler.java:106) at android.os.Looper.loopOnce(Looper.java:201) at android.os.Looper.loop(Looper.java:288) at android.app.ActivityThread.main(ActivityThread.java:7839) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003) Caused by: android.database.sqlite.SQLiteException: near "timestamp": syntax error (code 1 SQLITE_ERROR): , while compiling: CREATE TABLE IF NOT EXISTS SearchHistory( history TEXT PRIMARY KEY NOT NULL timestamp INTEGER NOT NULL ) at android.database.sqlite.SQLiteConnection.nativePrepareStatement(Native Method) at android.database.sqlite.SQLiteConnection.acquirePreparedStatement(SQLiteConnection.java:1047) at android.database.sqlite.SQLiteConnection.prepare(SQLiteConnection.java:654) at android.database.sqlite.SQLiteSession.prepare(SQLiteSession.java:590) at android.database.sqlite.SQLiteProgram.(SQLiteProgram.java:62) at android.database.sqlite.SQLiteStatement.(SQLiteStatement.java:34) at android.database.sqlite.SQLiteDatabase.executeSql(SQLiteDatabase.java:1920) at android.database.sqlite.SQLiteDatabase.execSQL(SQLiteDatabase.java:1842) at androidx.sqlite.db.framework.FrameworkSQLiteDatabase.execSQL(FrameworkSQLiteDatabase.kt:246) at com.jerboa.db.AppDBKt$MIGRATION_17_18$1.migrate(AppDB.kt:527) at androidx.room.RoomOpenHelper.onUpgrade(RoomOpenHelper.kt:91) at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper$OpenHelper.onUpgrade(FrameworkSQLiteOpenHelper.kt:253) at android.database.sqlite.SQLiteOpenHelper.getDatabaseLocked(SQLiteOpenHelper.java:416) at android.database.sqlite.SQLiteOpenHelper.getWritableDatabase(SQLiteOpenHelper.java:316) at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper$OpenHelper.getWritableOrReadableDatabase(FrameworkSQLiteOpenHelper.kt:232) at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper$OpenHelper.innerGetDatabase(FrameworkSQLiteOpenHelper.kt:190) at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper$OpenHelper.getSupportDatabase(FrameworkSQLiteOpenHelper.kt:151) at androidx.sqlite.db.framework.FrameworkSQLiteOpenHelper.getWritableDatabase(FrameworkSQLiteOpenHelper.kt:104) at androidx.room.RoomDatabase.inTransaction(RoomDatabase.kt:638) at androidx.room.RoomDatabase.assertNotSuspendingTransaction(RoomDatabase.kt:457) at com.jerboa.db.AccountDao_Impl.getAllSync(AccountDao_Impl.java:289) at com.jerboa.db.AccountRepository.getAllSync(AppDB.kt:227) at com.jerboa.db.AccountViewModel.(AppDB.kt:610) at com.jerboa.db.AccountViewModelFactory.create(AppDB.kt:634) at androidx.lifecycle.ViewModelProvider$Factory.create(ViewModelProvider.kt:83) at androidx.lifecycle.ViewModelProvider.get(ViewModelProvider.kt:187) at androidx.lifecycle.ViewModelProvider.get(ViewModelProvider.kt:153) at androidx.lifecycle.ViewModelLazy.getValue(ViewModelLazy.kt:53) at androidx.lifecycle.ViewModelLazy.getValue(ViewModelLazy.kt:35) at com.jerboa.MainActivity.getAccountViewModel(MainActivity.kt:117) at com.jerboa.MainActivity.onCreate(MainActivity.kt:128) at android.app.Activity.performCreate(Activity.java:8051) at android.app.Activity.performCreate(Activity.java:8031) at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1329) at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3608) ... 12 more
 CREATE TABLE IF NOT EXISTS SearchHistory(
                    history TEXT PRIMARY KEY NOT NULL
                    timestamp INTEGER NOT NULL 
                )
its missing a comma between history and timestamp

This should be working now, thanks for catching this.

MV-GH · 2023-06-28T05:25:00Z

It still crashes at startup but for a different reason this time. The best way to test the migration is to install a version with a DB behind the current. and then install the new app.

The stacktrace now is

Process: com.jerboa.debug, PID: 12543
java.lang.RuntimeException: Unable to start activity ComponentInfo{com.jerboa.debug/com.jerboa.MainActivity}: java.lang.IllegalStateException: Migration didn't properly handle: SearchHistory(com.jerboa.db.SearchHistory).
Expected:
TableInfo{name='SearchHistory', columns={text=Column{name='text', type='TEXT', affinity='2', notNull=true, primaryKeyPosition=1, defaultValue='undefined'}, timestamp=Column{name='timestamp', type='INTEGER', affinity='3', notNull=true, primaryKeyPosition=0, defaultValue='undefined'}}, foreignKeys=[], indices=[]}
Found:
TableInfo{name='SearchHistory', columns={history=Column{name='history', type='TEXT', affinity='2', notNull=true, primaryKeyPosition=1, defaultValue='undefined'}, timestamp=Column{name='timestamp', type='INTEGER', affinity='3', notNull=true, primaryKeyPosition=0, defaultValue='undefined'}}, foreignKeys=[], indices=[]}

And this is because in your migration your column is named history. But inside your entity the column has name "text".

|@Entity
data class SearchHistory(
    @PrimaryKey @ColumnInfo(name = "text") val text: String, // Should be history or migration should be text
    @ColumnInfo(name = "timestamp") val timestamp: Long,
)

dessalines

This needs a lot of work, because you didn't look at how the other tables were done, and tried to build it from scratch. The SearchHistory table needs some work, as well as its own viewmodel like the other two tables, that can be passed into activities as necessary.

app/src/main/java/com/jerboa/db/AppDB.kt

app/src/main/java/com/jerboa/MainActivity.kt

app/src/main/java/com/jerboa/ui/components/community/list/CommunityListViewModel.kt

wkoomson · 2023-07-03T14:38:26Z

Sounds good, I'll add another change shortly to make search history its own view model and address the rest of the feedback. One question, I added the timestamp column because there was a request to display history entries sorted in reverse chronological order. Is this still desired? If not I can remove that column.

…

On Mon, Jul 3, 2023, 6:52 AM Dessalines ***@***.***> wrote: ***@***.**** requested changes on this pull request. This needs a lot of work, because you didn't look at how the other tables were done, and tried to build it from scratch. The SearchHistory table needs some work, as well as its own viewmodel like the other two tables, that can be passed into activities as necessary. ------------------------------ In app/src/main/java/com/jerboa/db/AppDB.kt <#871 (comment)>: > @@ -142,8 +149,30 @@ val APP_SETTINGS_DEFAULT = AppSettings( usePrivateTabs = false, secureWindow = false, blurNSFW = true, + saveSearchHistory = true, +) + ***@***.*** +data class SearchHistory( + @PrimaryKey @ColumnInfo(name = "text") val text: String, No, use auto-gen'd primary keys like the other example. 2ndly, don't name these columns names which might be protected keywords in sql or kotlin. Name it search_term or something. 3rd: These search terms should almost certainly be attached to an account, so have a foreign key link to account.id ------------------------------ In app/src/main/java/com/jerboa/db/AppDB.kt <#871 (comment)>: > @@ -142,8 +149,30 @@ val APP_SETTINGS_DEFAULT = AppSettings( usePrivateTabs = false, secureWindow = false, blurNSFW = true, + saveSearchHistory = true, +) + ***@***.*** +data class SearchHistory( + @PrimaryKey @ColumnInfo(name = "text") val text: String, + @ColumnInfo(name = "timestamp") val timestamp: Long, This column isn't necessary, the inserts are going to be in order anyway by the primary key. ------------------------------ In app/src/main/java/com/jerboa/db/AppDB.kt <#871 (comment)>: > @@ -173,6 +202,9 @@ interface AppSettingsDao { @query("SELECT * FROM AppSettings limit 1") fun getSettings(): LiveData<AppSettings> + @query("SELECT * FROM AppSettings limit 1") Why did this get added? The livedata is already above this. ------------------------------ In app/src/main/java/com/jerboa/db/AppDB.kt <#871 (comment)>: > ) ***@***.*** +interface SearchHistoryDao { + @query("SELECT * FROM SearchHistory") + fun history(): Flow<List<SearchHistory>> Use LiveData like the other examples. Don't code from scratch: use the conventions currently here. ------------------------------ In app/src/main/java/com/jerboa/db/AppDB.kt <#871 (comment)>: > @@ -224,10 +256,26 @@ class AccountRepository(private val accountDao: AccountDao) { } } +class SearchHistoryRepository( + private val searchHistoryDao: SearchHistoryDao, + private val appSettingsDao: AppSettingsDao, +) { + fun history(): Flow<List<SearchHistory>> = searchHistoryDao.history() + + suspend fun insert(item: SearchHistory) { + if (appSettingsDao.settings().first().saveSearchHistory) { Why is this necessary? It should be connected to an account, not the appsettings, so it'll already have the account.id in the form. There's also no need to do a check on this insert. If you have an appsetting to disable search, that should be done outside of / before this SQL logic. ------------------------------ In app/src/main/java/com/jerboa/db/AppDB.kt <#871 (comment)>: > @@ -242,6 +290,7 @@ class AppSettingsRepository( @workerthread suspend fun update(appSettings: AppSettings) { appSettingsDao.updateAppSettings(appSettings) + if (!appSettings.saveSearchHistory) searchHistoryDao.clear() IMO this isn't necessary, but its up to you. The saved search history doesn't really need to clear anything, it just needs to visually not show it. ------------------------------ In app/src/main/java/com/jerboa/db/AppDB.kt <#871 (comment)>: > @@ -469,14 +518,32 @@ val MIGRATION_16_17 = object : Migration(16, 17) { } } +val MIGRATION_17_18 = object : Migration(17, 18) { + override fun migrate(database: SupportSQLiteDatabase) { + database.execSQL(UPDATE_APP_CHANGELOG_UNVIEWED) + database.execSQL( + "ALTER TABLE AppSettings add column save_search_history INTEGER NOT NULL default 1", + ) + database.execSQL( + """ + CREATE TABLE IF NOT EXISTS SearchHistory( + history TEXT PRIMARY KEY NOT NULL, See above. Primary key issue, column names, and unecessary timestamp column. ------------------------------ In app/src/main/java/com/jerboa/MainActivity.kt <#871 (comment)>: > } class MainActivity : AppCompatActivity() { private val siteViewModel by viewModels<SiteViewModel>() + private val communityListViewModel by viewModels<CommunityListViewModel>() { + CommunityListViewModelFactory((application as JerboaApplication).searchHistoryRepository) Why did you not make the searchhistory a viewmodel like the other tables? There's no reason to try to bundle it into another one. ------------------------------ In app/src/main/java/com/jerboa/ui/components/community/list/CommunityListViewModel.kt <#871 (comment)>: > -class CommunityListViewModel : ViewModel(), Initializable { - override var initialized by mutableStateOf(false) +class CommunityListViewModelFactory(private val repository: SearchHistoryRepository) : No, just make the searchhistory its own viewmodel like the other examples, and pass in either the viewmodel, or the searchHistoryViewModel.observeAsState() into the activities. — Reply to this email directly, view it on GitHub <#871 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGSOE3OUU3CPFQ2NJAKKWTXOLFDNANCNFSM6AAAAAAZSTA66M> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

dessalines · 2023-07-05T15:48:09Z

One question, I added the timestamp column because there was a request to
display history entries sorted in reverse chronological order. Is this
still desired?

You can just use the primary key for sorting (most recent at the top, or id desc). I don't see why anyone would need any other sort. So ya remove that column.

MV-GH

It is also missing the exported 20 schema

app/src/main/res/values/strings.xml

- Moved SearchHistoryViewModel to separate file - Updated version to 21

dessalines · 2023-07-14T18:32:53Z

app/src/main/java/com/jerboa/db/AppDBMigrations.kt

+        )
+        database.execSQL(
+            "CREATE INDEX index_SearchHistory_account_id ON SearchHistory(account_id)",
+        )


Looks much better, thanks.

dessalines · 2023-07-14T18:35:15Z

app/src/main/java/com/jerboa/db/AppDBMigrations.kt

+            """
+                CREATE TABLE IF NOT EXISTS SearchHistory(
+                    id INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, 
+                    account_id INTEGER,


account_id should also be not null, no? And it'd probably be clearer to move the references / fk relation into this line.

dessalines · 2023-07-14T18:35:57Z

app/src/main/java/com/jerboa/db/dao/SearchHistoryDao.kt

+    suspend fun insert(item: SearchHistory)
+
+    @Query("DELETE FROM SearchHistory WHERE account_id IS :accountId AND search_term = :searchTerm")
+    suspend fun delete(accountId: Int?, searchTerm: String)


account_id should be required.

dessalines · 2023-07-14T18:36:29Z

app/src/main/java/com/jerboa/db/entity/SearchHistory.kt

+        name = "account_id",
+        index = true,
+    )
+    val accountId: Int?,


Same here, not optional.

dessalines · 2023-07-14T18:41:30Z

app/src/main/java/com/jerboa/db/repository/SearchHistoryRepository.kt

+    private val searchHistoryDao: SearchHistoryDao,
+) {
+    fun history(): LiveData<List<SearchHistory>> = searchHistoryDao.history()
+        .map { history ->


Don't sort / distinct in code, sort using the @Query in sql.

dessalines · 2023-07-14T18:48:16Z

app/src/main/java/com/jerboa/ui/components/community/list/CommunityListActivity.kt

@@ -49,6 +57,8 @@ fun CommunityListActivity(
    siteViewModel: SiteViewModel,
    blurNSFW: Boolean,
    drawerState: DrawerState,
+    appSettingsViewModel: AppSettingsViewModel,


Seems pointless to bring in the entire appSettingsViewModel here. Just add saveSearchHistory as a param.

dessalines · 2023-07-14T18:52:50Z

app/src/main/java/com/jerboa/ui/components/community/list/CommunityListActivity.kt

@@ -60,9 +70,20 @@ fun CommunityListActivity(
        communityListViewModel.setCommunityListFromFollowed(siteViewModel)
    }

+    val saveSearchHistory by remember {


Not necessary.

dessalines · 2023-07-14T18:53:50Z

app/src/main/java/com/jerboa/ui/components/community/list/CommunityListActivity.kt

+    val searchHistory by remember(account) {
+        searchHistoryViewModel.searchHistory
+            .map { history -> history.filter { it.accountId == account?.id } }
+    }.observeAsState()


I thought there was a function that takes in account_id to filter by that already? If not, one needs to be added.

dessalines · 2023-07-14T18:56:42Z

app/src/main/java/com/jerboa/db/AppDBContainer.kt

+    val appSettingsRepository by lazy {
+        AppSettingsRepository(database.appSettingsDao(), database.searchHistoryDao())
+    }
+    val searchHistoryRepository by lazy { SearchHistoryRepository(database.searchHistoryDao()) }


Just add this new one alongside the other two, there's no need to embed them.

dessalines · 2023-07-14T18:57:22Z

app/src/main/java/com/jerboa/db/AppDBMigrations.kt

+            """,
+        )
+        database.execSQL(
+            "CREATE INDEX index_SearchHistory_account_id ON SearchHistory(account_id)",


consistent naming: idx_search_history_account

dessalines · 2023-09-26T01:14:05Z

Stale PR. I can re-open if necessary.

wkoomson requested review from dessalines and twizmwazin as code owners June 24, 2023 16:25

twizmwazin suggested changes Jun 25, 2023

View reviewed changes

app/src/main/java/com/jerboa/ui/components/community/list/CommunityListActivity.kt Outdated Show resolved Hide resolved

wkoomson closed this Jun 28, 2023

wkoomson force-pushed the main branch 2 times, most recently from 5bc65c0 to 13a9e0c Compare June 28, 2023 03:10

wkoomson added 5 commits June 27, 2023 20:36

Sort searches in reverse-chronological order, add saveSearchHistory s…

75629e4

…etting

Clear all search history when the option is switched off

a3c3e2a

Also, do not insert search history items when saveSearchHistory is false.

Fix formatting

a673e55

Add strings for search history UI

1d7a380

wkoomson reopened this Jun 28, 2023

wkoomson requested a review from twizmwazin June 28, 2023 03:51

MV-GH requested changes Jun 28, 2023

View reviewed changes

app/src/main/java/com/jerboa/ui/components/settings/lookandfeel/LookAndFeelActivity.kt Outdated Show resolved Hide resolved

MV-GH reviewed Jun 28, 2023

View reviewed changes

app/src/main/java/com/jerboa/MainActivity.kt Outdated Show resolved Hide resolved

wkoomson added 2 commits June 27, 2023 21:41

Add strings for search history UI

d09a79d

Merge branch 'main' of github.com:wkoomson/jerboa

322be51

dessalines requested changes Jul 3, 2023

View reviewed changes

MV-GH mentioned this pull request Jul 8, 2023

Add toggle in settings to hide descriptions in navbar #995

Merged

in progress

9045040

wkoomson added 2 commits July 11, 2023 21:48

Add separate ViewModel for SearchHistory

ce1de11

Merge branch 'search-history'

efe7f18

wkoomson requested review from dessalines and MV-GH July 12, 2023 04:54

MV-GH requested changes Jul 12, 2023

View reviewed changes

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved

wkoomson added 3 commits July 13, 2023 08:32

Fix formatting and add schema

544e92d

Merge remote-tracking branch 'upstream/main'

b2de395

- Moved SearchHistoryViewModel to separate file - Updated version to 21

Fix formatting

c08574c

dessalines reviewed Jul 14, 2023

View reviewed changes

dessalines closed this Sep 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add local search history to the community list screen #871

Add local search history to the community list screen #871

wkoomson commented Jun 24, 2023 •

edited

Loading

wkoomson commented Jun 24, 2023

MV-GH commented Jun 24, 2023

twizmwazin commented Jun 24, 2023

wkoomson commented Jun 24, 2023

MV-GH commented Jun 24, 2023

wkoomson commented Jun 24, 2023

MV-GH left a comment •

edited

Loading

wkoomson commented Jun 28, 2023

MV-GH commented Jun 28, 2023 •

edited

Loading

dessalines left a comment

wkoomson commented Jul 3, 2023 via email

dessalines commented Jul 5, 2023

MV-GH left a comment •

edited

Loading

dessalines Jul 14, 2023

dessalines Jul 14, 2023

dessalines Jul 14, 2023

dessalines Jul 14, 2023

dessalines Jul 14, 2023

dessalines Jul 14, 2023

dessalines Jul 14, 2023

dessalines Jul 14, 2023

dessalines Jul 14, 2023

dessalines Jul 14, 2023

dessalines commented Sep 26, 2023

Add local search history to the community list screen #871

Add local search history to the community list screen #871

Conversation

wkoomson commented Jun 24, 2023 • edited Loading

wkoomson commented Jun 24, 2023

MV-GH commented Jun 24, 2023

twizmwazin commented Jun 24, 2023

wkoomson commented Jun 24, 2023

MV-GH commented Jun 24, 2023

wkoomson commented Jun 24, 2023

MV-GH left a comment • edited Loading

Choose a reason for hiding this comment

wkoomson commented Jun 28, 2023

MV-GH commented Jun 28, 2023 • edited Loading

dessalines left a comment

Choose a reason for hiding this comment

wkoomson commented Jul 3, 2023 via email

dessalines commented Jul 5, 2023

MV-GH left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dessalines commented Sep 26, 2023

wkoomson commented Jun 24, 2023 •

edited

Loading

MV-GH left a comment •

edited

Loading

MV-GH commented Jun 28, 2023 •

edited

Loading

MV-GH left a comment •

edited

Loading