Add setting (off by default) to prevent screenshots. #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This really doesn't belong under look and feel but I don't think that needs to be addressed here necessarily. I think in a separate PR we need to reorganize the settings into more pages. |
dessalines
reviewed
Jun 16, 2023
| @@ -98,6 +100,14 @@ class MainActivity : ComponentActivity() { | |||
| AppSettingsViewModelFactory((application as JerboaApplication).appSettingsRepository) | |||
| } | |||
|
|
|||
| private fun updateWindowFlags(appSettings: AppSettings) { | |||
There was a problem hiding this comment.
Instead of passing in the entire app settings, just pass in secure window.
And this function should be externalized (if possible), probably moved to JerboaTheme which has other window functions.
There was a problem hiding this comment.
Cool, moved into the Theme and rebased.
camporter
force-pushed
the
prevent_screenshots_setting
branch
from
d505a97 to
7c4680f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #573
Thoughts on this under
Look and feel? Maybe aSecurity/Privacysettings area would be nice to have.