🐛: fix check permissions hanging for some users by unpromisifying it #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alexdanilowicz
changed the title
|
resolves: #463 |
|
fudge, this doesn't work in released version. totally hangs still. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems for 35% of users, get started would hang. At first, I thought this was an initialize problem, but Amplitude (and all the support tickets) suggests that actually initialize never starts and the permission check just hangs. Hangs meaning it never resolves.
I actually was able to repro locally by removing full disk for my terminal, and then adding it and restarting the app. It hanged. When I logged, it seemed that the promise never resolved. it just waited and waited. not sure what caused that. But i think we can just un-promisify it and just call it at the render level. I can no longer repro.