Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed single quote error #47

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

maxwilkinsontech
Copy link

Hi,

When the field content contains a single quote, I get the error:

Uncaught SyntaxError: missing ) after argument list

This is due to the value widget template variable not being escaped and causing situations like:

wrapper.quill.clipboard.dangerouslyPasteHTML(0, '{"delta":"{\"ops\":[{\"insert\":\"'\\n\"}]}","html":"<p>'</p>"}')

which is causing the error above.

When this error occurs, the quilljs widget does not render at all.

Adding the escape filter to the dangerouslyPasteHTML function argument seems to fix this bug.

Cheers.

LeeHanYeong and others added 19 commits July 14, 2020 10:06
* Fix content damage on validation error
* Fix fixtures format and enable null values
* Fixed non-saving data of dynamically created quills
* Poetry fix
* Setup fix

Co-authored-by: Michał Dyczko <[email protected]>
this allows the db backend to apply any optimizations it might want/need
closes LeeHanYeong#26

Co-authored-by: proxi <[email protected]>
* Bump to Quill Version 1.3.7

Bump to Quill Version 1.3.7 - This version of Quill fixes Quill Vuln slab/quill#2438

Here is the change commit to fix the vuln in Quill slab/quill#2439

The Vuln is described here: https://ossindex.sonatype.org/vuln/d96c07dd-81f9-41f6-b2bd-531143bcaeab

* Adding JS/CSS include instructions from README.md

Resolves issue [LeeHanYeong#33](LeeHanYeong#33)
…ttribute 'json_string' (LeeHanYeong#41)

* Bump to Quill Version 1.3.7

Bump to Quill Version 1.3.7 - This version of Quill fixes Quill Vuln slab/quill#2438

Here is the change commit to fix the vuln in Quill slab/quill#2439

The Vuln is described here: https://ossindex.sonatype.org/vuln/d96c07dd-81f9-41f6-b2bd-531143bcaeab

* Adding JS/CSS include instructions from README.md

Resolves issue [LeeHanYeong#33](LeeHanYeong#33)

* adding None return for json_string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants