Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split model in input/resolved #40

Merged
merged 9 commits into from
Oct 2, 2024
Merged

refactor: split model in input/resolved #40

merged 9 commits into from
Oct 2, 2024

Conversation

jnicoulaud-ledger
Copy link
Contributor

@jnicoulaud-ledger jnicoulaud-ledger commented Oct 1, 2024 •
edited
Loading

Intermediate step to split model in 2 phases:

  • input: maps JSON schema
  • resolved:
    • URLs have been fetched
    • References have been inlined (not done in this PR)
    • Constants have been inlined (not done in this PR)
    • Enums have been inlined (not done in this PR)
    • Selectors have been converted to 4 bytes form (not done in this PR)

+ many bug fixes

@jnicoulaud-ledger jnicoulaud-ledger marked this pull request as ready for review October 2, 2024 07:51
@jnicoulaud-ledger jnicoulaud-ledger requested a review from a team as a code owner October 2, 2024 07:51
@jnicoulaud-ledger jnicoulaud-ledger merged commit d268342 into main Oct 2, 2024
5 of 6 checks passed
@jnicoulaud-ledger jnicoulaud-ledger deleted the split-model branch October 2, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jnicoulaud-ledger jnicoulaud-ledger

Labels
sources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jnicoulaud-ledger