feat: cleanups, setup conversion CLI, more extensive tests #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(intermediate PR) - enabled more linters - fixed PEP8 (camel case names) - fixed some bandit warnings - fixed `NameType` type not serializing correctly - added ledger-asset-dapps as submodule, generalized tests to work on all ledger-asset-dapps descriptors - moved registries submodules to tests - grouped test utilities instead of duplicating - added test utilities to properly display parameterized test cases - added model serialization schema + round trip tests - added conversion round trip tests - removed docs/ with duplicated schema, it is in registry - added `ERC7730Converter` interface similar to linter interface - implemented CLI for conversion commands - started cleaning up converter code (WIP, see FIXMEs)
github-actions
bot
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(intermediate PR)
NameTypetype not serializing correctlyERC7730Converterinterface similar to linter interface