Load includes into json + rountrip test with content check + fix mappers #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClaireGuerreGiordano
force-pushed
the
newschema
branch
from
d336825
to
f896756
Compare
jnicoulaud-ledger
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette pr contient les changements dont nous avons discuté hier:
Chargement des includes avant la transformation du json en objet python
Fix des mappers cassés suite au nouveau schema
Amélioration du roundtrip test en comparant le json original (avec includes intégré) au json serialisé depuis le modèle objet.
sur ce dernier point, 2 tests ne passent pas à cause de l’objet screen qui n’a pas de schema, donc pas de modèle objet