Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support all Etherscan based chains, add support for file:// URLs, improve linter outputs #107

Merged
merged 5 commits into from
Oct 22, 2024

Conversation

jnicoulaud-ledger
Copy link
Contributor

@jnicoulaud-ledger jnicoulaud-ledger commented Oct 21, 2024

  • only ETHERSCAN_API_KEY is required now
  • switch client from requests to httpx (HTTP 2, typed, more easily extensible)
  • add disk cache to HTTP client
  • add etherscan rate limiting on HTTP client
  • add support for file:// protocol on HTTP client
  • improve HTTP client interface to not require RootModel anymore

unrelated changes:

  • multithread linter
  • cosmetic/output improvements to linter

- only `ETHERSCAN_API_KEY` is required now
- switch client from `requests` to `httpx` (HTTP 2, typed, more easily extensible)
- add disk cache to HTTP client
- add etherscan rate limiting on HTTP client
- improve client interface to not require `RootModel` anymore
@jnicoulaud-ledger jnicoulaud-ledger marked this pull request as ready for review October 22, 2024 09:42
@jnicoulaud-ledger jnicoulaud-ledger requested a review from a team as a code owner October 22, 2024 09:42
@jnicoulaud-ledger jnicoulaud-ledger enabled auto-merge (squash) October 22, 2024 10:08
@jnicoulaud-ledger jnicoulaud-ledger changed the title feat: switch to Etherscan v2 API feat: switch to Etherscan v2 API, add support for file:// URLs Oct 22, 2024
@jnicoulaud-ledger jnicoulaud-ledger changed the title feat: switch to Etherscan v2 API, add support for file:// URLs feat: switch to Etherscan v2 API, add support for file:// URLs, improve linter outputs Oct 22, 2024
@jnicoulaud-ledger jnicoulaud-ledger changed the title feat: switch to Etherscan v2 API, add support for file:// URLs, improve linter outputs feat: support all Etherscan based chains, add support for file:// URLs, improve linter outputs Oct 22, 2024
src/erc7730/common/client.py Show resolved Hide resolved
@jnicoulaud-ledger jnicoulaud-ledger merged commit eaef420 into main Oct 22, 2024
5 checks passed
@jnicoulaud-ledger jnicoulaud-ledger deleted the etherscan-v2 branch October 22, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants