Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/celo check duplicate #8478

Draft
wants to merge 46 commits into
base: develop
Choose a base branch
from
Draft

Conversation

Wozacosta
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 9:50am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 9:50am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 9:50am
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 9:50am

@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common labels Nov 25, 2024
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Nov 25, 2024

Mobile Bundle Checks

Comparing d62634f against c3107ab.

⚠️ main.ios.jsbundle bundle size significantly increased: 63.3mb -> 64.4mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 63.3mb -> 64.4mb. Please check if this is expected.

Desktop Bundle Checks

Comparing d62634f against 51a753c.

⚠️ renderer bundle size significantly increased: 37.3mb -> 38.3mb. Please check if this is expected.
⚠️ ethereum-cryptography/secp256k1 library is now duplicated in renderer (regression)
⚠️ @noble/hashes/_assert library is now duplicated in renderer (regression)
⚠️ @ethereumjs/rlp library is now duplicated in renderer (regression)
⚠️ ethereum-cryptography/keccak library is now duplicated in renderer (regression)
⚠️ ethereum-cryptography/utils library is now duplicated in renderer (regression)
⚠️ @ethereumjs/util library is now duplicated in renderer (regression)
⚠️ cross-fetch library is now duplicated in renderer (regression)
πŸš€ @ethersproject/abi library is no longer duplicated in renderer
πŸš€ readable-stream library is no longer duplicated in renderer
πŸš€ safe-buffer library is no longer duplicated in renderer
πŸš€ eth-lib/lib/hash library is no longer duplicated in renderer
πŸš€ fp-ts/lib/Either library is no longer duplicated in renderer
πŸš€ ethereumjs-util library is no longer duplicated in renderer
πŸš€ io-ts library is no longer duplicated in renderer
πŸš€ @celo/connect/lib/utils/formatter library is no longer duplicated in renderer
πŸš€ @celo/wallet-base library is no longer duplicated in renderer
πŸš€ multibase library is no longer duplicated in renderer
πŸš€ multicodec library is no longer duplicated in renderer
πŸš€ isarray library is no longer duplicated in renderer
πŸš€ eth-lib/lib/bytes library is no longer duplicated in renderer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants