Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVE-14970: prevent undefined error on swap mobile #8459

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

andreicovaciu
Copy link
Contributor

@andreicovaciu andreicovaciu commented Nov 25, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Prevent undefined error on LLM.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@andreicovaciu andreicovaciu requested a review from a team as a code owner November 25, 2024 11:02
Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Nov 26, 2024 7:47am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 7:47am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 7:47am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 7:47am

@live-github-bot live-github-bot bot added the common Has changes in live-common label Nov 25, 2024
Copy link
Contributor

@Justkant Justkant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should return an error for this case instead of a silent return like the unsubscribed case
The error could be something like family not supported: ${family} making it clear that we don't support the family we received from the params

@andreicovaciu
Copy link
Contributor Author

We should return an error for this case instead of a silent return like the unsubscribed case The error could be something like family not supported: ${family} making it clear that we don't support the family we received from the params

Updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants