Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QAA] adding Aptos send test #8450

Open
wants to merge 1 commit into
base: feat/integrate-aptos
Choose a base branch
from

Conversation

VicAlbr
Copy link
Contributor

@VicAlbr VicAlbr commented Nov 22, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Add e2e test

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Nov 22, 2024 2:59pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 22, 2024 2:59pm
native-ui-storybook ⬜️ Ignored (Inspect) Nov 22, 2024 2:59pm
react-ui-storybook ⬜️ Ignored (Inspect) Nov 22, 2024 2:59pm

@VicAlbr VicAlbr marked this pull request as ready for review November 22, 2024 14:57
@VicAlbr VicAlbr requested review from a team as code owners November 22, 2024 14:57
@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common labels Nov 22, 2024
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Nov 22, 2024

Mobile Bundle Checks

Comparing 7a07c32 against a6c762e.

⚠️ main.ios.jsbundle bundle size significantly increased: 63.3mb -> 64mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 63.3mb -> 64mb. Please check if this is expected.

Desktop Bundle Checks

Comparing 7a07c32 against a6c762e.

⚠️ renderer bundle size significantly increased: 37.3mb -> 37.7mb. Please check if this is expected.
⚠️ @noble/hashes/blake2b library is now duplicated in renderer (regression)
⚠️ @wry/trie library is now duplicated in renderer (regression)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant