Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QAA-312][DETOX] Speculos add accounts tests #8446

Open
wants to merge 3 commits into
base: support/qaa_331_cli_detox_speculos
Choose a base branch
from
Open

[QAA-312][DETOX] Speculos add accounts tests #8446

wants to merge 3 commits into from

Conversation

abdurrahman-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached. (no need)
  • Covered by automatic tests.
  • Impact of the changes:
    • LLM E2E Tests

📝 Description

Improving Speculos add account test
Separate each coin by file to enable parallelisation

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Nov 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 10:07am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 10:07am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 10:07am
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 10:07am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Nov 22, 2024
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_312_detox_speculos_add_accounts branch 3 times, most recently from 5dcd88e to 5c7e7b3 Compare November 25, 2024 09:09
@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common ui Has changes in the design system library tools Has changes in tools automation CI/CD stuff translations Translation files have been touched screenshots Screenshots have been updated cli labels Nov 25, 2024
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_312_detox_speculos_add_accounts branch from 5c7e7b3 to a879fb2 Compare November 25, 2024 09:11
@live-github-bot live-github-bot bot removed the cli label Nov 25, 2024
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_312_detox_speculos_add_accounts branch from a879fb2 to 7358a9f Compare November 25, 2024 09:13
@live-github-bot live-github-bot bot removed desktop Has changes in LLD common Has changes in live-common ui Has changes in the design system library tools Has changes in tools automation CI/CD stuff translations Translation files have been touched screenshots Screenshots have been updated labels Nov 25, 2024
@abdurrahman-ledger abdurrahman-ledger marked this pull request as ready for review November 25, 2024 09:17
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_312_detox_speculos_add_accounts branch from 7358a9f to c8b7fc8 Compare November 25, 2024 09:37
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_312_detox_speculos_add_accounts branch from c8b7fc8 to 97ec518 Compare November 26, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharamboure-ledger bharamboure-ledger bharamboure-ledger approved these changes

Assignees

@abdurrahman-ledger abdurrahman-ledger

Labels
mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdurrahman-ledger @bharamboure-ledger