Fix Ledger Vulnerabilities #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: app update audit fix
UI Update: function name
- Move debug-helpers/debug.h inclusion out of DEBUG=1 condition - Keep -g flag only for debug builds
- change 'Blooo' to 'Acre' - generate golden snapshots
- Remove inclusion of debug-helpers/debug.h from default CFLAGS. - Add inclusion of debug-helpers/debug.h to CFLAGS only when DEBUG=1. - Ensure CFLAGS includes -g for debugging when DEBUG=1.
- change "Blooo" to "Acre" - generate golden snapshots
Fix: address Ledger's audit vulnerabilities
…rinting methods on real devices.
fix:bump version
- Replace hardcoded `domain_separator_hash` with `abi_encoded_chain_id` for mainnet and testnet variants. - Add `domain_separator_typehash`. - Add function `compute_domain_separator_hash` - Update `compute_tx_hash` to include domain separator hash computation.
…signing fix(handler/withdraw): correct issue in `compute_tx_hash`
|
@tdejoigny-ledger I reopened this PR instead, the #1 one looks corrupted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.