Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add APIServerLoadBalancer setting to enable/disable API server LB, allow adding ports, configure firewall #26

Merged
merged 45 commits into from
Sep 2, 2024
Merged

Add APIServerLoadBalancer setting to enable/disable API server LB, allow adding ports, configure firewall #26

merged 45 commits into from
Sep 2, 2024

Conversation

hrak
Copy link
Member

@hrak hrak commented Aug 19, 2024

Issue #, if available:

Description of changes:

This includes the following changes:

  • Update to K8s 1.27.16
  • Update to Go 1.22
  • Refactor flag handling, add version flag
  • Introduce APIServerLoadBalancer in CloudStackCluster that allows enabling/disabling of API server load balancer, adding additional ports to LB, adding firewalling to the load balancer port, in a similar fashion as CAPO.

Testing performed:

Added/adapted several unit tests, tested in my dev env.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

hrak added 26 commits August 13, 2024 10:23
@hrak
refactor: rename OpenFirewallRules to CreateEgressFirewallRules
bd8117b
@hrak
fix: update default registry and tag
90c6782
@hrak
refactor: rename getOfferingID to getNetworkOfferingID
9238940
@hrak
feat: add version flag and refactor flag handling
72838bc
@hrak
chore: remove staticcheck
1b5abba
@hrak
fix: add generate-conversion to generate-all
878a2f9
@hrak
chore: remove some unused code and update some comments
5e96113
@hrak
feat: Allow firewall rules to be defined for the API server load bala…
8acd547 
…ncer

also allows load balancing additional ports to the API server
@hrak
chore: Update to k8s v1.27.16
795d4e0
@hrak
chore: Update to Go 1.22
a5971d5
@hrak
fix: use klog.FlushAndExit instead of os.Exit
c10a42d
@hrak
fix: fix LDFLAGS for docker build
7e9e6e2
@hrak
fix(ci): set fetch-depth 0 to get tags as well
3b67bab
@hrak
fix: Add missing leader election flags, remove cloud-config-file flag
0e9a10a 
+ remove statically defined and deprecated port
@hrak
fix: Add condition to AddToLBIfNeeded which checks if API server lb i…
bc2002e 
…s enabled
@hrak
feat: Log end of reconciliation
6dfe5bd
@hrak
fix: Watch for changes in CloudStackCluster in the isonet controller …
6362bc1 
…and reconcile if needed
@hrak
chore: fix incorrect function name in comment
f01f7d5
@hrak
fix: Make sure lb rules are deleted when a port is removed from addit…
df2577f 
…ionalPorts
@hrak
fix: Delete related fw rule when a port is removed from additionalPor…
af09d28 
…ts + add test
@hrak
fix: Add predicate to only reconcile on generation change of cscluster
0447baf
@hrak
fix: Use async cs client for fw/lb rule deletion
0c9fd17
@hrak
fix: Make sure VM's get assigned to lb rules when a change in lb rule…
4aa2d64 
…s occurs.
@hrak
fix: Fetch clustername from isonet labels
a0648f6
@hrak
fix: Add some type checking
c289b43
@hrak
fix: Updated the mapper funcs so they actually work
0bfddd7
FarnazBGH
FarnazBGH previously approved these changes Aug 19, 2024
View reviewed changes
hrak added 2 commits August 21, 2024 14:54
@hrak
chore: add 0.5.x and 0.5.x series to the metadata.yaml
3758502
@hrak
fix: Solved several issues with the firewalling implementation
5f6e709 
- prevent deletion of lb/fw rules not created by CAPC by using tags
- delete all lb/fw rules when the lb is disabled
- the fw rule lookup map only allowed 1 rule per port
@hrak hrak requested a review from FarnazBGH August 23, 2024 12:35
hrak added 16 commits August 27, 2024 07:47
@hrak
fix: Some old find/replace mistake
04008c3
@hrak
feat: Consider that isonet outgoing IP might not be the same as LB IP
c9f806c 
- isoNet.Status.PublicIPID is now the isonet outgoing IP
- Added isonet.Status.PublicIPAddress for easy lookup of the outgoing IP
- Automatically add the outgoing IP to allowed CIDRs
@hrak
feat: Allow isolated network CIDR to be configured
cdf9f2a
@hrak
fix(tests): Add webhook tests for validity of fd/network name and net…
f5ab380 
…work CIDR
@hrak
fix: Remove lint from test target
c26adc4
@hrak
fix: Separate load balancer reconciliation from GetOrCreateIsolatedNe…
8bd85c7 
…twork
@hrak
fix: Tag the outgoing IP
e86ef49
@hrak
fix(tests): Update the tests for ReconcileLoadBalancer
b010f50
@hrak
chore: Fix copy/pasta in DeleteLoadBalancerRule error msg
2cca369
@hrak
fix: The resource type for a lb rule is LoadBalancer, not LoadBalance…
8bda463 
…rRule

because screw consistency (a fw rule is FirewallRule)
@hrak
fix: Remove double strings.ToLower
49040f3
@hrak
fix: Break out of loop when instance is found
8a0b6b3
@hrak
fix: Reduce excessive logging/events
5835fce
@hrak
fix: Revert to the old behavior of isonet outgoing IP = loadbalancer …
bf8d10a 
…IP for now
@hrak
fix(tests): Remove injection of ginkgo recover statements
00692df 
This was not particularly helping in troubleshooting
@hrak
fix(tests): remove need for REPO_ROOT env var
f472057
@hrak
Copy link
Member Author

hrak commented Aug 30, 2024

FYI existing clusters will have to have created_by_CAPC = 1 tags added to any existing LB and FW rules before upgrading

FarnazBGH
FarnazBGH approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@FarnazBGH FarnazBGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hrak hrak merged commit db5cf80 into main Sep 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FarnazBGH FarnazBGH FarnazBGH approved these changes

@lanord lanord Awaiting requested review from lanord

@kasperhendriks kasperhendriks Awaiting requested review from kasperhendriks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hrak @FarnazBGH