fix: Use async cs client for lb rule deletion

Leaseweb · Aug 15, 2024 · 46ef783 · 46ef783
1 parent f8d2c27
commit 46ef783
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/pkg/cloud/isolated_network.go b/pkg/cloud/isolated_network.go
@@ -286,9 +286,12 @@ func (c *client) ReconcileLoadBalancerRules(isoNet *infrav1.CloudStackIsolatedNe
 
 		if !slices.Contains(ports, intport) {
 			success, err := c.DeleteLoadBalancerRule(ruleID)
-			if err != nil || !success {
+			if err != nil {
 				return errors.Wrap(err, "deleting load balancer rule")
 			}
+			if !success {
+				return errors.New("delete load balancer rule returned unsuccessful")
+			}
 		}
 	}
 	// Update isoNet status with the current list of loadbalancer rule ID's.
@@ -326,8 +329,8 @@ func (c *client) CreateLoadBalancerRule(isoNet *infrav1.CloudStackIsolatedNetwor
 
 // DeleteLoadBalancerRule deletes an existing load balancer rule.
 func (c *client) DeleteLoadBalancerRule(id string) (bool, error) {
-	p := c.cs.LoadBalancer.NewDeleteLoadBalancerRuleParams(id)
-	resp, err := c.cs.LoadBalancer.DeleteLoadBalancerRule(p)
+	p := c.csAsync.LoadBalancer.NewDeleteLoadBalancerRuleParams(id)
+	resp, err := c.csAsync.LoadBalancer.DeleteLoadBalancerRule(p)
 	if err != nil {
 		c.customMetrics.EvaluateErrorAndIncrementAcsReconciliationErrorCounter(err)