Connect four #23
Open
Connect four #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Joe Fredette I want to send this as a seperate PR but it is based directly upon PR 13. How am I really supposed to do this or is this correct? |
|
If you rebase now, those extra commits should go away. Generally I just wait for the first to get merged, there's not really a good way to specify dependencies |
| @@ -2,6 +2,7 @@ source 'http://rubygems.org' | |||
|
|
|||
| gem 'rspec' | |||
| gem 'pry' | |||
| gem 'debugger' | |||
There was a problem hiding this comment.
We can lose this -- that's what pry is for! Just use binding.pry where you would use debugger. plop right into a running ruby interpreter! :)
|
I'll take a better look at this later. It looks neat, but could stand some refactoring to separate the internal game logic from the rendering of messages to the user, and needs some general idiomatic cleaning (parens around method definitions, mostly) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A connect four playing AI.