Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: public key creation based on e and n #2747

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Conversation

xdubx
Copy link
Contributor

@xdubx xdubx commented Oct 14, 2024

Description

Fix public key creation. And add an autodiscover key for e.g. nextcloud.

example config for env vars

      LEAN_OIDC_ENABLE: "true"
      LEAN_OIDC_CREATE_USER : "true"
      LEAN_OIDC_AUTO_DISCOVER: https://replace/index.php
      LEAN_OIDC_PROVIDER_URL: https://replace # Nextcloud base URL
      LEAN_OIDC_CLIENT_ID : "replace"
      LEAN_OIDC_CLIENT_SECRET : "replace"
      LEAN_OIDC_FIELD_FIRSTNAME: "name"

Link to ticket

#2009 (comment)

Type

  • Fix
  • [] Feature
  • Cleanup

Screenshot of the result

If your change affects the user interface, you should include a screenshot of the result with the pull request.

@xdubx xdubx requested a review from a team as a code owner October 14, 2024 17:45
@xdubx xdubx requested review from marcelfolaron and removed request for a team October 14, 2024 17:46
@CLAassistant
Copy link

CLAassistant commented Oct 14, 2024

CLA assistant check
All committers have signed the CLA.

@marcelfolaron
Copy link
Contributor

Thank you!

@@ -14,6 +14,8 @@
use Leantime\Domain\Users\Repositories\Users as UserRepository;
use OpenSSLAsymmetricKey;
use Symfony\Component\HttpFoundation\Response;
use phpseclib3\Crypt\PublicKeyLoader;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurts my head that phpseclib3 is not PSR-4 compliant. :) Oh well

@marcelfolaron marcelfolaron merged commit 0f4fdb0 into Leantime:master Oct 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants