Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ap-southeast-3 (Jakarta) to unsupportedIO2Regions #487

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PatMyron
Copy link

@PatMyron PatMyron commented Jun 2, 2022

https://pricing.us-east-1.amazonaws.com/offers/v1.0/aws/AmazonEC2/current/index.json (3GB+)
https://aws.amazon.com/ebs/pricing/

curl -s https://pricing.us-east-1.amazonaws.com/offers/v1.0/aws/AmazonEC2/current/index.json | grep -B 2 '"io2' | grep 'region' | sort | uniq -c

Wonder if this list should be reversed like it is in https://github.com/cloudutil/EBS-Optimizer/blob/fe9118e51810690958f1a0f8d1c922f1602eeca6/volume_configuration.go#L61 since the newest regions don't seem to launch with support

Issue Type

  • Bugfix Pull Request

Summary

Code contribution checklist

  1. I hereby allow the Copyright holder the rights to distribute this piece of
    code under any software license.
  2. The contribution fixes a single existing github issue, and it is linked
    to it.
  3. The code is as simple as possible, readable and follows the idiomatic Go
    guidelines.
  4. All new functionality is covered by automated test cases so the overall
    test coverage doesn't decrease.
  5. No issues are reported when running make full-test.
  6. Functionality not applicable to all users should be configurable.
  7. Configurations should be exposed through Lambda function environment
    variables which are also passed as parameters to the
    CloudFormation
    and
    Terraform
    stacks defined as infrastructure code.
  8. Global configurations set from the infrastructure stack level should also
    support per-group overrides using tags.
  9. Tags names and expected values should be similar to the other existing
    configurations.
  10. Both global and tag-based configuration mechanisms should be tested and
    proven to work using log output from various test runs.
  11. The logs should be kept as clean as possible (use log levels as
    appropriate) and formatted consistently to the existing log output.
  12. The documentation is updated to cover the new behavior, as well as the
    new configuration options for both stack parameters and tag overrides.
  13. A code reviewer reproduced the problem and can confirm the code
    contribution actually resolves it.

@cristim
Copy link
Member

cristim commented Jun 13, 2022

Good point, I'm hoping new regions would ship with this, I find it strange new regions still ship with IO1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants