-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI testing for all feature flag combinations and fix all reported errors #475
Conversation
When running
|
All these unresolved links occur because they are excluded when the |
Let's run doc check only with all features. I care much more about the links working on docs.rs than locally. |
In that case, this PR shouldn't have any further actions needed, at least for now. |
To validate everything's working as expected, try removing some of the code that depends on feature flags. This should trigger the errors we're looking for. For example, parts like this mentioned /// Remove this cfg in the 'src/input_map.rs'
#[cfg(feature = "asset")]
use bevy::asset::Asset; |
Objective
Make sure we thoroughly test all feature-related code and updates.
Solution
Cover all combinations of features our crate offers when running CI tests for
clippy
,doc-check
,doc-test
,test
, andcompile-check
.For instance, given the current existence of four features:
asset
,ui
,block_ui_interactions
, andegui
, the new CI testing will include scenarios like:--no-default-features
--all-features
--features=asset
--features=ui
--features=block_ui_interactions
--features=egui
--features=asset,ui
--features=asset,block_ui_interactions
--features=asset,egui
--features=ui,block_ui_interactions
--features=ui,egui
--features=block_ui_interactions,egui
--features=asset,ui,block_ui_interactions
--features=asset,ui,egui
--features=asset,block_ui_interactions,egui
--features=ui,block_ui_interactions,egui
This ensures we catch any regressions or issues related to the features.
TODO
doc-check
)Changelog