feat: utilize split in existing rewards calculation #117
Conversation
| ELSE | ||
| total_staker_operator_payout - floor(total_staker_operator_payout * 0.10) | ||
| total_staker_operator_payout - floor(total_staker_operator_payout * COALESCE(oas.split, 1000) / 10000.0) |
There was a problem hiding this comment.
Do we know what type the output of COALESCE(oas.split, 1000) / 10000.0 is? We want the total_staker_operator_payout * split to be a numeric * numeric and not a numeric * float
There was a problem hiding this comment.
I mean the existing 0.10 is a float / double. So I've stuck with that. I believe the floor does round it down to a whole number.
pkg/rewards/5_goldRfaeStakers.go
Outdated
| @@ -106,12 +107,23 @@ staker_operator_total_tokens AS ( | |||
| FLOOR(staker_proportion * tokens_per_day_decimal) as total_staker_operator_payout | |||
| FROM staker_proportion | |||
| ), | |||
| -- Calculate the token breakdown for each (staker, operator) pair | |||
| -- Include the operator_pi_split_snapshots table | |||
| operator_pi_splits_cte AS ( | |||
There was a problem hiding this comment.
Nit: we don't use cte in naming anywhere
There was a problem hiding this comment.
I did that to prevent a conflict with the existing operator_pi_splits table in the DB. Needed something to explicitly differentiate it.
There was a problem hiding this comment.
Not sure why this is needed at all. Why not just reference operator_pi_split_snapshots where you need it? You don’t really gain any advantage by selecting just a few columns from it
There was a problem hiding this comment.
Ah good point. I don't know why I did it that way. Fixed in 0eb7412
Utilize the
OperatorAVSSplitandOperatorPISplitin the existing rewards v1 and Programmatic incentives calculation (instead of the hardcoded 10% split).