feat: relax indexedChainState to ChainState for retrieval #943
Conversation
| @@ -28,7 +28,14 @@ func (cs *ChainState) GetOperatorStateByOperator(ctx context.Context, blockNumbe | |||
| return nil, err | |||
There was a problem hiding this comment.
can we move these methods to eth reader and remove this struct?
Not sure why we need a separate struct for this
There was a problem hiding this comment.
If we're caching the operator sockets, maybe we should keep this struct separate
| // buildSocketMap returns a map from operatorID to socket address for the operators in the operatorsByQuorum | ||
| func (cs *ChainState) buildSocketMap(ctx context.Context, operatorsByQuorum core.OperatorStakes) (map[core.OperatorID]string, error) { | ||
| socketMap := make(map[core.OperatorID]string) | ||
| for _, quorum := range operatorsByQuorum { |
There was a problem hiding this comment.
isn't the key the quorum and the value map[OperatorIndex]OperatorStake here?
There was a problem hiding this comment.
yes exactly. This loop is to get all the operator ID and their socket from all quorums
There was a problem hiding this comment.
one way to address this would be to preload cache initially by querying every single operator in the current block. Then for the following requests, query the current set of operators, query the logs by filtering on SocketUpdate event, find any socket updates for existing operators, and refresh sockets for all operators.
Then the subsequent requests will only cost 2 eth calls
core/eth/state.go
Outdated
| @@ -38,7 +45,12 @@ func (cs *ChainState) GetOperatorState(ctx context.Context, blockNumber uint, qu | |||
| return nil, err | |||
| } | |||
|
|
|||
| return getOperatorState(operatorsByQuorum, uint32(blockNumber)) | |||
| socketMap, err := cs.buildSocketMap(ctx, operatorsByQuorum) | |||
There was a problem hiding this comment.
does this mean whenever we call this method, it will query the chain # operators times?
this seems very inefficient, should we cache this?
There was a problem hiding this comment.
yes I expect this too. I can add socket map to the ChainState cache and only query if the operator is missing from the socket map. Although, that means we might need to add a refresh or a failover somewhere so that we don't use the old socket addresses after operators make an updater. Lmk what you think
| @@ -28,7 +28,14 @@ func (cs *ChainState) GetOperatorStateByOperator(ctx context.Context, blockNumbe | |||
| return nil, err | |||
There was a problem hiding this comment.
If we're caching the operator sockets, maybe we should keep this struct separate
hopeyen
force-pushed
the
hope/distributed-retrieval
branch
from
b8566be to
59b7ff7
Compare
hopeyen
force-pushed
the
hope/distributed-retrieval
branch
from
a2a3f52 to
d393a7e
Compare
hopeyen
force-pushed
the
hope/distributed-retrieval
branch
from
d393a7e to
36b9280
Compare
Why are these changes needed?
Enable retrieval client to run without indexing
Checks