Add additional queue metrics #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianoaix
reviewed
Nov 20, 2024
| @@ -71,6 +73,20 @@ func NewMetrics(httpPort string, logger logging.Logger) *Metrics { | |||
| }, | |||
| []string{"size_bucket"}, | |||
| ), | |||
| QueueCapacity: promauto.With(reg).NewGauge( | |||
There was a problem hiding this comment.
This is configured, so doesn't look it should be exported via metric again.
Utilization is a division of queue size (already exported) by capacity.
There was a problem hiding this comment.
It's convenient for visualizing the capacity on grafana dashboard. If we change the capacity it should also change on the dashboard.
jianoaix
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Added max queue capacity so we can do computations to get utilization (useful if we want to scale using percentage of the request pool). Also adds overall request pool utilization for convenience.
This PR also adds GRPC metrics similar to #891
Checks