Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove traffic generator threshold flags #368

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Remove traffic generator threshold flags #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tools/traffic/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,5 @@ run: build
TRAFFIC_GENERATOR_NUM_INSTANCES=1 \
TRAFFIC_GENERATOR_REQUEST_INTERVAL=1s \
TRAFFIC_GENERATOR_DATA_SIZE=1000 \
TRAFFIC_GENERATOR_ADV_THRESHOLD=80 \
TRAFFIC_GENERATOR_QUORUM_THRESHOLD=100 \
TRAFFIC_GENERATOR_RANDOMIZE_BLOBS=true \
./bin/server
4 changes: 0 additions & 4 deletions tools/traffic/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ type Config struct {
NumInstances uint
RequestInterval time.Duration
DataSize uint64
ConfirmationThreshold uint8
AdversarialThreshold uint8
LoggingConfig common.LoggerConfig
RandomizeBlobs bool
InstanceLaunchInterval time.Duration
Expand All @@ -37,8 +35,6 @@ func NewConfig(ctx *cli.Context) (*Config, error) {
NumInstances: ctx.GlobalUint(flags.NumInstancesFlag.Name),
RequestInterval: ctx.Duration(flags.RequestIntervalFlag.Name),
DataSize: ctx.GlobalUint64(flags.DataSizeFlag.Name),
ConfirmationThreshold: uint8(ctx.GlobalUint(flags.QuorumThresholdFlag.Name)),
AdversarialThreshold: uint8(ctx.GlobalUint(flags.AdversarialThresholdFlag.Name)),
LoggingConfig: *loggerConfig,
RandomizeBlobs: ctx.GlobalBool(flags.RandomizeBlobsFlag.Name),
InstanceLaunchInterval: ctx.Duration(flags.InstanceLaunchIntervalFlag.Name),
Expand Down
14 changes: 0 additions & 14 deletions tools/traffic/flags/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,18 +53,6 @@ var (
Required: true,
EnvVar: common.PrefixEnvVar(envPrefix, "DATA_SIZE"),
}
AdversarialThresholdFlag = cli.StringFlag{
Name: common.PrefixFlag(FlagPrefix, "adv-threshold"),
Usage: "Adversarial threshold between 0 and 100",
Required: true,
EnvVar: common.PrefixEnvVar(envPrefix, "ADV_THRESHOLD"),
}
QuorumThresholdFlag = cli.StringFlag{
Name: common.PrefixFlag(FlagPrefix, "quorum-threshold"),
Usage: "Quorum threshold between 0 and 100",
Required: true,
EnvVar: common.PrefixEnvVar(envPrefix, "QUORUM_THRESHOLD"),
}
RandomizeBlobsFlag = cli.BoolFlag{
Name: common.PrefixFlag(FlagPrefix, "randomize-blobs"),
Usage: "Whether to randomzie blob data",
Expand Down Expand Up @@ -92,8 +80,6 @@ var requiredFlags = []cli.Flag{
NumInstancesFlag,
RequestIntervalFlag,
DataSizeFlag,
AdversarialThresholdFlag,
QuorumThresholdFlag,
}

var optionalFlags = []cli.Flag{
Expand Down
Loading