Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holesky testnet deployment #360

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Holesky testnet deployment #360

merged 2 commits into from
Mar 18, 2024

Conversation

0x0aa0
Copy link
Contributor

@0x0aa0 0x0aa0 commented Mar 18, 2024

Why are these changes needed?

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

string public existingDeploymentInfoPath = string(bytes("./script/deploy/existing/Holesky_preprod.json"));
string public deployConfigPath = string(bytes("./script/deploy/holesky/config/preprod.config.json"));
string public outputPath = string.concat("script/deploy/holesky/output/holesky_preprod_deployment_data.json");
//string public existingDeploymentInfoPath = string(bytes("./script/deploy/existing/Holesky_preprod.json"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove if not needed

"deploymentBlock": 1168409
},
"permissions": {
"eigenDABatchConfirmer": "0xC0996A3Cc9ECF2A96115C117f6Da99FA80F525eB",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 0xA723AA9E2168E7Bb705c331B048cc1e0bE31b1e4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0x0aa0 0x0aa0 merged commit 54fce30 into master Mar 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants