Test multiple quorums in synthetic client test #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddimore
reviewed
Mar 8, 2024
| numQuorums := rand.Intn(maxNumQuorums) + 1 | ||
| securityParams := make([]*core.SecurityParam, numQuorums) | ||
| for i := 0; i < numQuorums; i++ { | ||
| quorumThreshold := rand.Intn(25) + 50 // number between 50 and 75 |
There was a problem hiding this comment.
nit: may be add comment on choice of above magic numbers
ian-shim
force-pushed
the
synthetic-client-test-multiquorum
branch
from
8a15061 to
0147bc0
Compare
ian-shim
force-pushed
the
synthetic-client-test-multiquorum
branch
from
0147bc0 to
a948007
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Make synthetic client test disperse to multiple quorums with randomized security parameters.
Checks