Minor fixes (#358)

api/docs/disperser.md

@@ -160,7 +160,7 @@ AuthenticationData contains the signature of the BlobAuthHeader.
 
 ### BlobAuthHeader
 BlobAuthHeader contains information about the blob for the client to verify and sign.
-- Once payments are enabled, the BlobAuthHeader the KZG commitment to the blob, which the client
+- Once payments are enabled, the BlobAuthHeader will contain the KZG commitment to the blob, which the client
 will verify and sign. Having the client verify the KZG commitment instead of calculating it avoids
 the need for the client to have the KZG structured reference string (SRS), which can be large.
 The signed KZG commitment prevents the disperser from sending a different blob to the DA Nodes

api/proto/disperser/disperser.proto

@@ -53,7 +53,7 @@ message AuthenticatedReply {
 }
 
 // BlobAuthHeader contains information about the blob for the client to verify and sign.
-// - Once payments are enabled, the BlobAuthHeader the KZG commitment to the blob, which the client
+// - Once payments are enabled, the BlobAuthHeader will contain the KZG commitment to the blob, which the client
  // will verify and sign. Having the client verify the KZG commitment instead of calculating it avoids
 // the need for the client to have the KZG structured reference string (SRS), which can be large.
 // The signed KZG commitment prevents the disperser from sending a different blob to the DA Nodes

core/data.go

@@ -104,7 +104,7 @@ type BlobHeader struct {
 	QuorumInfos []*BlobQuorumInfo
 
 	// AccountID is the account that is paying for the blob to be stored
-	AccountID AccountID `json:"account_id"`
+	AccountID AccountID
 }
 
 func (b *BlobHeader) GetQuorumInfo(quorum QuorumID) *BlobQuorumInfo {

disperser/apiserver/server.go

@@ -104,7 +104,7 @@ func (s *DispersalServer) DisperseBlobAuthenticated(stream pb.Disperser_Disperse
 		return api.NewInvalidArgError(fmt.Sprintf("error receiving next message: %v", err))
 	}
 
-	request, ok := in.Payload.(*pb.AuthenticatedRequest_DisperseRequest)
+	request, ok := in.GetPayload().(*pb.AuthenticatedRequest_DisperseRequest)
 	if !ok {
 		return api.NewInvalidArgError("missing DisperseBlobRequest")
 	}
@@ -148,7 +148,7 @@ func (s *DispersalServer) DisperseBlobAuthenticated(stream pb.Disperser_Disperse
 		return api.NewInvalidArgError(fmt.Sprintf("error receiving next message: %v", err))
 	}
 
-	challengeReply, ok := in.Payload.(*pb.AuthenticatedRequest_AuthenticationData)
+	challengeReply, ok := in.GetPayload().(*pb.AuthenticatedRequest_AuthenticationData)
 	if !ok {
 		return api.NewInvalidArgError("expected AuthenticationData")
 	}
@@ -223,7 +223,7 @@ func (s *DispersalServer) disperseBlob(ctx context.Context, blob *core.Blob, aut
 		return nil, api.NewInvalidArgError(err.Error())
 	}
 
-	s.logger.Debug("received a new blob request", "origin", origin, "securityParams", strings.Join(securityParamsStrings, ", "))
+	s.logger.Debug("received a new blob dispersal request", "origin", origin, "securityParams", strings.Join(securityParamsStrings, ", "))
 
 	if s.ratelimiter != nil {
 		err := s.checkRateLimitsAndAddRates(ctx, blob, origin, authenticatedAddress)

node/grpc/server.go

@@ -83,7 +83,7 @@ func (s *Server) serveDispersal() error {
 	addr := fmt.Sprintf("%s:%s", localhost, s.config.InternalDispersalPort)
 	listener, err := net.Listen("tcp", addr)
 	if err != nil {
-		s.logger.Fatalf("Could not start tcp listener: %w", err)
+		s.logger.Fatalf("Could not start tcp listener: %v", err)
 	}
 
 	opt := grpc.MaxRecvMsgSize(1024 * 1024 * 1024) // 1 GiB
@@ -107,7 +107,7 @@ func (s *Server) serveRetrieval() error {
 	addr := fmt.Sprintf("%s:%s", localhost, s.config.InternalRetrievalPort)
 	listener, err := net.Listen("tcp", addr)
 	if err != nil {
-		s.logger.Fatalf("Could not start tcp listener: %w", err)
+		s.logger.Fatalf("Could not start tcp listener: %v", err)
 	}
 
 	opt := grpc.MaxRecvMsgSize(1024 * 1024 * 300) // 300 MiB

node/grpc/utils.go

@@ -21,7 +21,7 @@ func GetBatchHeader(in *pb.StoreChunksRequest) (*core.BatchHeader, error) {
 	var batchRoot [32]byte
 	copy(batchRoot[:], in.GetBatchHeader().GetBatchRoot())
 	batchHeader := core.BatchHeader{
-		ReferenceBlockNumber: uint(in.BatchHeader.ReferenceBlockNumber),
+		ReferenceBlockNumber: uint(in.GetBatchHeader().GetReferenceBlockNumber()),
 		BatchRoot:            batchRoot,
 	}
 	return &batchHeader, nil

retriever/eth/chain_client.go

@@ -22,7 +22,7 @@ type chainClient struct {
 	logger    logging.Logger
 }
 
-func NewChainClient(ethClient common.EthClient, logger logging.Logger) *chainClient {
+func NewChainClient(ethClient common.EthClient, logger logging.Logger) ChainClient {
 	return &chainClient{
 		ethClient: ethClient,
 		logger:    logger,