Launcher3 A15 Merge #4818
Draft
Launcher3 A15 Merge #4818
+85,764
−38,940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: 343770316 Test: manual - record a video Flag: com.android.launcher3.use_activity_overlay Change-Id: I74346f060ea93dbc8fc0a1c3290d4996d89ec062
Flag: com.android.launcher3.enable_recents_in_taskbar Test: none Bug: 315354060 Change-Id: I5b757558ab8e5905b4142146901b68f55d0c7ef8
Change-Id: I8c248849c89363c910d4b3d6123c98f3107819f2
…down and keyboard"" into main
shown Implement keyboard hiding logic: Hide keyboard when scrolling down (y > mLastY) unless already requested (mRequestedHideKeyboard). Track hide request state to prevent redundant calls. New added logic: Only hide keyobard while dragging the scrollbar result video: https://photos.app.goo.gl/e4dYUUiUN3BujNUz9 Bug: 333967597 Flag: EXEMPT bugfix Test: Manual Change-Id: Id672763c69cbb37aeb7a1fd3f17eb168de9f49b4
Auto-generated-cl: translation import Change-Id: I4e0f4e61a5e6957bd6d52ede541d1dfe0523ab74
Auto-generated-cl: translation import Change-Id: I7d47742f878876e358fec1130708bae36149f801
This CL adds some logs to help analyzing why recents button with 3 button navigation sometimes don't open Overview. Bug: 337954957 Test: NONE Flag: EXEMPT Adding logs to debug issue Change-Id: I44a799319eca667b04d4e78a38ade796fc3b69fb
Bug: 325088842 Test: Presubmit passes Flag: EXEMPT test-only Change-Id: Id2856b2016b2e1ba467c7b8e830631f5253d6b8c
from AppIcon press in overview Test: Updated unit tests Flag: EXEMPT not a major feature/ user visible change Bug: b/326231756 Change-Id: I9e53cd3ec41dd2475ba90ea8fab2fb7a90f5e158
This CL replaces the live tile with the snapshot after rotating in fake orientation. The animateRotation function was created to extract the rotation logic to guarantee that switchToScreenshot call will only happen when there is a running task. Fix: 326410493 Flag: EXEMPT bug fix Test: Manual. Instructions in the bug description. Change-Id: I9d5e1b5ca803f8f8072702b37206a73b8d8a10ed
…riginating from AppIcon press in overview" into main
Call this updateView() in reset to ensure states are correct before animating. bug: 341053089 Test: manually - video: https://drive.google.com/file/d/18ZSAEplL1Lk5ij3IHlwtRh1GQ6GhrXX1/view?usp=sharing Flag: Aconfig com.android.launcher3.enable_private_space Nextfood Change-Id: I2c825a7fd7d9a5faad8fbbb70d0f40294f715a42
Test: Manual - animations Bug: 336704871 Flag: EXEMPT bugfix Change-Id: I80629128a0730ca85d0313d15af806ddf840e82b
…748c8e -s ours am skip reason: contains skip directive Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27660191 Change-Id: If41e975c615955d48be92f4703a8b8f43423485b Signed-off-by: Automerger Merge Worker <[email protected]>
This change updates the background animation at the All Set page for foldables of a certain dimension. Fix: 326231525 Fix: 335057950 Test: Run All Set page in multiple device types and observe the background animation Flag: EXEMPT bugfix Change-Id: I1197d689ab76f79a80d0be46ad96ada78666c214
As demonstrated in ag/27287153, the actual Smartspace doesn't have any
top padding, but the qsb_preview does.
- Turns out, ShortcutAndWidgetContainer sets padding on its children.
- The actual Smartspace has padding removed by overriding the
`setPadding` method in SmartspaceViewContainer. (See ag/13562740.)
This CL updates ShortcutAndWidgetContainer.java to not add padding for
either the actual or the preview Smartspace. It makes use of
`R.id.search_container_workspace` to identify the applicable cases,
rather than checking class types or names. This way, there is no
Pixel-specific logic added.
Before: https://hsv.googleplex.com/6335187293044736?node=18
After: https://hsv.googleplex.com/5450651931770880?node=18
Actual Smartspace, for reference:
- https://hsv.googleplex.com/6083634648842240?node=14
Note the `isChildQsb` also returns true for the QsbContainerView. Since
that class already has the same `setPadding` override:
- https://cs.android.com/android/platform/superproject/main/+/main:packages/apps/Launcher3/src/com/android/launcher3/qsb/QsbContainerView.java;l=147-150;drc=e58aaf1802e43f73bbd417658c1c4c42e2fe28fd
This CL does't affect its padding.
Flag: EXEMPT bugfix
Bug: 338601960
Test: Go to Wallpaper & style preview for Home screen.
Change-Id: I5b6f7752cfee556b815c83e9df85f9e74f23ab4b
Change-Id: Ie6d6fd0b06ec0b89b3dc461d4bf2d920f79d50e7
bug: 345007467 Test: manually video: before: https://drive.google.com/file/d/1XzpD-R48WRKFBeDlHXU5xSGgc50ZON8o/view?usp=sharing after: https://drive.google.com/file/d/1VBKZluzxvpP8ucs_uylk5esRlm9KzrZb/view?usp=sharing Flag: Aconfig com.android.launcher3.enable_private_space Nextfood Change-Id: I1db4bdf244b37b4c4cf55cb0d70d4011fee7de90
… GestureNavigationSettingsObserver" into main
Change-Id: Iea3c9f2d9eed0811fc0826531569e0ab110e61a4
The banner should be aligned to the start of the screen, not the center. This CL fixes DWB position for split tasks when device is unfolded. Fix: 348200661 Bug: 345789862 Flag: EXEMPT bugfix Test: Manual. Add a Digital Wellbeing (DWB) timer to 2 apps. Open these two apps in split mode. Unfold the device and go to Overview. The DWB banner should aligned correctly. (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3d088e3899cfca516dfa8ae9699691ece2b914d9) Merged-In: I0544b4a8eb85b00196373c8a4368e680abab222b Change-Id: I0544b4a8eb85b00196373c8a4368e680abab222b
…48087'] into 24Q3-release. Change-Id: Ic311bb2906ad81b79cfd0c9d4f5487d5dc3f01c8
This CL prevents returning launcher in getVisibleLauncher method when isHomeVisible is true but Launcher is not started. Bug: 337954957 Bug: 331947116 Flag: EXEMPT bugfix Test: Manual. With 3-button-nav. Open a video from -1 scren (not in Youtube app), press recent button. More instructions in b/337954957#comment26. (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6a4c142b5b77ccb8c439e29209b6dfd04a4690d0) Merged-In: I40edafdab5457666474de2c0368158a9c1c05fb0 Change-Id: I40edafdab5457666474de2c0368158a9c1c05fb0
…04180'] into 24Q3-release. Change-Id: I8c3c2a6fe033e4c539522aab1e568ad27cc2e531
Flag: EXEMPT launcher_broadcast_installed_apps Bug: 322314760 Test: manually tested (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:30a3acc7796850caa6be51b6c46d26d35dfb0b3c) Merged-In: I28a3ee1fb2c5c382ea8789b6e966c80db1abf0e0 Change-Id: I28a3ee1fb2c5c382ea8789b6e966c80db1abf0e0
- We do the same in Launcher for real rotation Fix: 348113790 Test: manual Flag: EXEMPT bugfix (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:bde639236f8e73608e3fd14fecdbbe5267f4607e) Merged-In: Ibd5f42db439cd94a389f7aaf6fe2db317c11cd67 Change-Id: Ibd5f42db439cd94a389f7aaf6fe2db317c11cd67
Fix: 349072279 Test: Verify that Select mode is only available from Menu in grid only Overview on tablets Flag: EXEMPT bugfix (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2026c800165865b3323f449a2d9cda22e9231598) Merged-In: Icd0d8303547b45d3653696812c51ce2c2bfd410b Change-Id: Icd0d8303547b45d3653696812c51ce2c2bfd410b
…02855', 'googleplex-android-review.googlesource.com/27951519', 'googleplex-android-review.googlesource.com/27976521'] into 24Q3-release. Change-Id: I700dccc620c1f24e25094d8bd240156d4459e877
Flag: com.android.launcher3.enable_additional_home_animations Fixes: 343051344 Test: temp logs, launched apps from home, quickly swiped home while quick switching (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:9fb1f8043573d5bc3376f0786354fc8f7a9cf2cd) Merged-In: I91071d53f753eb7bc99305c46241de203bcfdc98 Change-Id: I91071d53f753eb7bc99305c46241de203bcfdc98
We can just remove the check since isSearchSupported has been launched. bug: 345648701 Test manually video - before: https://drive.google.com/file/d/1EwwRXrASusmqVixGWuKGnOQQyiDLE6Yy/view?usp=sharing after: https://drive.google.com/file/d/1OCvtxzbhRJrBMMM2JH_cOurQ-_BaALSA/view?usp=sharing Flag: com.android.launcher3.enable_private_space (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:e770f10d2a6a047c1ad7b1061f57c388dec4f913) Merged-In: I0ae19d342556aac4ee0b6e26b4cef8752c0beb38 Change-Id: I0ae19d342556aac4ee0b6e26b4cef8752c0beb38
…10982', 'googleplex-android-review.googlesource.com/28017557'] into 24Q3-release. Change-Id: I2705f435af3724834915649c216be5b9b5a9d125
In an effort to encourage users to look at Taskbar edu more thoroughly, this change makes it so users have to press the 'Done' button explicitly to close the taskbar edu window. This change also adds the ability for it to be dismissed by the back gesture. It only applies to the features edu, and not other taskbar educations. Fix: 349612575 Test: Manually run all versions of taskbar edu and ensure that the edu only goes away with back gesture, swipe up or clicking on the DONE button Flag: EXEMPT bugfix (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:17339843e76cb507413e1d22dcf0c7982e024379) Merged-In: I9c456b9efddc6de5f292d6a14b1ce9daee7efaa3 Change-Id: I9c456b9efddc6de5f292d6a14b1ce9daee7efaa3
…02349'] into 24Q3-release. Change-Id: I151b0b299990b21634a49ffc1b5a499bd30734b9
* RecentsView#onAttachedToWindow relies on splitSelectStateController being initialized, so we now do it before RecentsActivity calls setContentView() Bug: 332643607 Test: Couldn't repro before or after :( Flag: EXEMPT bugfix (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4276ee4897f59cfb1a2e432adfe54196b1a0dd2d) Merged-In: Ic26460e08ca74adcf6dcf31abc956ad57f4061c2 Change-Id: Ic26460e08ca74adcf6dcf31abc956ad57f4061c2
…73793'] into 24Q3-release. Change-Id: I63384015f7ad54b8e7c4caae31df5915add78004
- Also updated AnimatedFloat to accept a Consumer<Float>, so a lambda can be used as updateCallback with refernce to udpated value - Also updated PendingAnimation to accept Animator with TimedInterpolator without specifying SpringProperty Fix: 352195519 Test: manual Flag: EXEMPT bugfix (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:c378e64b757dbb83b6024be462a6752bc6a2c5f2) Merged-In: Ifb78c1bcd3ca215a5d214f986a107d0988bff13b Change-Id: Ifb78c1bcd3ca215a5d214f986a107d0988bff13b
Auto-generated-cl: translation import Bug: 347053373 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4bafcb8b1dd8d982eaa39c50ad0008539866ba5e) Merged-In: Ia4bc42b575811c5371e2a6a84c5b83e65f36b01c Change-Id: Ia4bc42b575811c5371e2a6a84c5b83e65f36b01c
…31687', 'googleplex-android-review.googlesource.com/28240994'] into 24Q3-release. Change-Id: I01869591a2667594683184770641529b09bcd80c
- This fixed a regression caused by ag/27904180, where -1 is no longer considered `visibleLauncher`. -1 still have Launcher being top activity, and recents animation will always fail - Added isInMinusOne in LauncherActivityInterface, and return Launcher in getVisibleLauncher for -1 case - -1 should be the only case where Launcher is top activity, but is not started Fix: 352254279 Test: Recents button from the following scenarios: Home, -1, apps, transparent apps, video from -1 Flag: EXEMPT bugfix (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1cd3fe27f229da4f7bb80a2e04d1416cc050fc94) Merged-In: I0898d202b9dd4742c0c7d2c0d6b340c748e8acf7 Change-Id: I0898d202b9dd4742c0c7d2c0d6b340c748e8acf7
…55751'] into 24Q3-release. Change-Id: I25c866ebe559df2c3a4eab38ff22d456f89471c0
Revert submission 27627108-b/339747262 Reason for revert: b/353914086 Fix: 353450667 Fix: 353914086 Bug: 339747262 Reverted changes: /q/submissionid:27627108-b/339747262 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2676385eb81b7048c8f169ebf3b80b695103e952) Merged-In: I9a71ee0fa4062b15e68eff41951f42d46ace19d3 Change-Id: I9a71ee0fa4062b15e68eff41951f42d46ace19d3
…97164'] into 24Q3-release. Change-Id: Iba1da3b5f49278b8a762194f0181d353cfb0d4d6
* Init sets mSplitSelectStateController which RecentsView then uses in onAttachedToWindow(). That needs to be set before it gets attached to the window, which happens in RecentsActivity#setContentView() Fixes: 332643607 Test: Only presubmit, issue not reproducible Flag: EXEMPT bugfix (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:aeecb1e8a5cabe9fc58af69f7b47764a96a08d76) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:eac1d34438209f266212b1bbe8c9704c2947dbcd) Merged-In: Icc555cad17b734e2a9c035991c19bbdc6b02de5d Change-Id: Icc555cad17b734e2a9c035991c19bbdc6b02de5d
…84306'] into 24Q3-release. Change-Id: Ib38362e5793569abe89c0a6dc6669470784fb454
Auto-generated-cl: translation import Bug: 347053373 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1a55c4180d907362e090b29ce1f3251be446715f) Merged-In: I6e6b45e8381a46584fa243216faccb9c3104fb47 Change-Id: I6e6b45e8381a46584fa243216faccb9c3104fb47
Auto-generated-cl: translation import Bug: 347053373 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:444b22f7e0c11ce7c86db658ce73981cc8b5b57b) Merged-In: Iefea5770ca226df91a814af1b611bab14e4b6c37 Change-Id: Iefea5770ca226df91a814af1b611bab14e4b6c37
…98173', 'googleplex-android-review.googlesource.com/28598174'] into 24Q3-release. Change-Id: Ia25ea9c081441409f32d49a0367b8765db59fe22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
android15-releasefrom AOSP #4760.Type of change
❌ General change (non-breaking change that doesn't fit the below categories like copyediting)
❌ Bug fix (non-breaking change which fixes an issue)
❌ New feature (non-breaking change which adds functionality)
✅ Breaking change (fix or feature that would cause existing functionality to not work as expected)