Made color changes trigger for a tap, not just a drag #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In previous versions the colors would not change for a tap, only for drags. Yet, on the bars, the pointer would move to the tapped position, suggesting this wasn't the intended behavior. This commit addresses this problem. This commit solves #66 Changes: The bars run the same code for taps as they do for drags. The color picker itself now responds to taps, to ensure a consistent experience. Minor refactoring by pulling repeated code out of if-else chains to outside the chain.
|
+1 |
Solmath
added a commit
to Solmath/HoloColorPicker
that referenced
this pull request
Aug 4, 2018
|
Closing this since it's stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous versions the colors would not change for a tap, only for drags.
Yet, on the bars, the pointer would move to the tapped position, suggesting
this wasn't the intended behavior. This commit addresses this problem.
This pull request solves #66 (Issue 66)
Changes:
The bars run the same code for taps as they do for drags.
The color picker itself now responds to taps, to ensure a consistent experience.
Minor refactoring by pulling repeated code out of if-else chains to outside the chain.