Skip to content

Commit

Permalink
Clean up
Browse files Browse the repository at this point in the history
  • Loading branch information
Lars Kuehmichel committed Oct 27, 2023
1 parent 927ee5f commit a17f51e
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions src/lightning_trainable/trainable/trainable.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import lightning
import os
import pathlib
import torch

from copy import deepcopy
Expand Down Expand Up @@ -62,10 +61,6 @@ def compute_metrics(self, batch, batch_idx) -> dict:
"""
raise NotImplementedError

def on_train_start(self):
# TODO: get metrics to track from compute_metrics
self.logger.log_hyperparams(self.hparams, ...)

def training_step(self, batch, batch_idx):
try:
metrics = self.compute_metrics(batch, batch_idx)
Expand Down

0 comments on commit a17f51e

Please sign in to comment.