Skip to content

Commit

Permalink
Fix versioning for only notify requested members (github#24271)
Browse files Browse the repository at this point in the history
Co-authored-by: Lucas Costi <[email protected]>
  • Loading branch information
vgrl and lucascosti authored Jan 16, 2022
1 parent 9e9be2c commit aefe963
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -57,42 +57,43 @@ Any team members that have set their status to "Busy" will not be selected for r
{% data reusables.user_settings.access_org %}
{% data reusables.organizations.specific_team %}
{% data reusables.organizations.team_settings %}
5. In the left sidebar, click **Code review**
1. In the left sidebar, click **Code review**
![Code review button](/assets/images/help/teams/review-button.png)
2. Select **Only notify requested team members.**
1. Select **Only notify requested team members.**
![Code review team notifications](/assets/images/help/teams/review-assignment-notifications.png)
3. Click **Save changes**.
1. Click **Save changes**.
{% endif %}

## Configuring auto assignment
{% data reusables.profile.access_org %}
{% data reusables.user_settings.access_org %}
{% data reusables.organizations.specific_team %}
{% data reusables.organizations.team_settings %}
5. In the left sidebar, click **Code review**
1. In the left sidebar, click **Code review**
![Code review button](/assets/images/help/teams/review-button.png)
6. Select **Enable auto assignment**.
1. Select **Enable auto assignment**.
![Auto-assignment button](/assets/images/help/teams/review-assignment-enable.png)
7. Under "How many team members should be assigned to review?", use the drop-down menu and choose a number of reviewers to be assigned to each pull request.
1. Under "How many team members should be assigned to review?", use the drop-down menu and choose a number of reviewers to be assigned to each pull request.
![Number of reviewers dropdown](/assets/images/help/teams/review-assignment-number.png)
8. Under "Routing algorithm", use the drop-down menu and choose which algorithm you'd like to use. For more information, see "[Routing algorithms](#routing-algorithms)."
1. Under "Routing algorithm", use the drop-down menu and choose which algorithm you'd like to use. For more information, see "[Routing algorithms](#routing-algorithms)."
![Routing algorithm dropdown](/assets/images/help/teams/review-assignment-algorithm.png)
9. Optionally, to always skip certain members of the team, select **Never assign certain team members**. Then, select one or more team members you'd like to always skip.
1. Optionally, to always skip certain members of the team, select **Never assign certain team members**. Then, select one or more team members you'd like to always skip.
![Never assign certain team members checkbox and dropdown](/assets/images/help/teams/review-assignment-skip-members.png)
{% ifversion ghes < 3.4 %}
1. Optionally, to only notify the team members chosen by code review assignment for each pull review request, under "Notifications" select **If assigning team members, don't notify the entire team.**
{%- endif %}
{% ifversion fpt or ghec or ghae-issue-5108 or ghes > 3.2 %}
11. Optionally, to include members of child teams as potential reviewers when assigning requests, select **Child team members**.
12. Optionally, to count any members whose review has already been requested against the total number of members to assign, select **Count existing requests**.
13. Optionally, to remove the review request from the team when assigning team members, select **Team review request**.
{%- else %}
10. Optionally, to only notify the team members chosen by code review assignment for each pull review request, under "Notifications" select **If assigning team members, don't notify the entire team.**
1. Optionally, to include members of child teams as potential reviewers when assigning requests, select **Child team members**.
1. Optionally, to count any members whose review has already been requested against the total number of members to assign, select **Count existing requests**.
1. Optionally, to remove the review request from the team when assigning team members, select **Team review request**.
{%- endif %}
14. Click **Save changes**.
1. Click **Save changes**.

## Disabling auto assignment
{% data reusables.profile.access_org %}
{% data reusables.user_settings.access_org %}
{% data reusables.organizations.specific_team %}
{% data reusables.organizations.team_settings %}
5. Select **Enable auto assignment** to remove the checkmark.
1. Select **Enable auto assignment** to remove the checkmark.
![Code review assignment button](/assets/images/help/teams/review-assignment-enable.png)
6. Click **Save changes**.
1. Click **Save changes**.
2 changes: 1 addition & 1 deletion data/features/only-notify-requested-members.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ versions:
fpt: '*'
ghec: '*'
ghes: '>=3.4'
ghae: '*'
ghae: 'issue-5108'

0 comments on commit aefe963

Please sign in to comment.