fixed versioning in nucleus and synapse binaries (#189)

* added support for versioning

* makefile formatting

.github/workflows/release-patch-wf.yml

@@ -59,6 +59,8 @@ jobs:
           tags: ${{ env.NUCLEUS_TAGS }}
           file: build/nucleus/Dockerfile
           push: true
+          build-args: |
+            VERSION=${{ steps.tag_version.outputs.new_tag }}
 
       - name: Build and push Synapse images
         uses: docker/[email protected]
@@ -67,3 +69,5 @@ jobs:
           tags: ${{ env.SYNAPSE_TAGS }}
           file: build/synapse/Dockerfile
           push: true
+          build-args: |
+            VERSION=${{ steps.tag_version.outputs.new_tag }}

.github/workflows/release.yml

@@ -110,6 +110,8 @@ jobs:
           tags: ${{ env.NUCLEUS_TAGS }}
           file: build/nucleus/Dockerfile
           push: true
+          build-args: |
+            VERSION=${{ steps.tag_version.outputs.new_tag }}
 
       - name: Build and push Synapse images
         uses: docker/[email protected]
@@ -118,3 +120,6 @@ jobs:
           tags: ${{ env.SYNAPSE_TAGS }}
           file: build/synapse/Dockerfile
           push: true
+          build-args: |
+            VERSION=${{ steps.tag_version.outputs.new_tag }}
+

Makefile

@@ -4,20 +4,23 @@ NUCLEUS_IMAGE_NAME ?= lambdatest/nucleus:latest
 SYNAPSE_DOCKER_FILE ?= ./build/synapse/Dockerfile
 SYNAPSE_IMAGE_NAME ?= lambdatest/synapse:latest
 
+REV_LIST ?= $(shell git rev-list --tags --max-count=1)
+VERSION ?= $(shell git describe --tags ${REV_LIST})
+
 usage:						## Show this help
 	@fgrep -h "##" $(MAKEFILE_LIST) | fgrep -v fgrep | sed -e 's/:.*##\s*/##/g' | awk -F'##' '{ printf "%-25s -> %s\n", $$1, $$2 }'
 
 lint:						## Runs linting
 	golangci-lint run
 
 build-nucleus-image:		## Builds nucleus docker image
-	docker build -t ${NUCLEUS_IMAGE_NAME} --file $(NUCLEUS_DOCKER_FILE) .
+	docker build --build-arg VERSION=${VERSION}-dev -t ${NUCLEUS_IMAGE_NAME} --file $(NUCLEUS_DOCKER_FILE) .
 
 build-nucleus-bin:			## Builds nucleus binary
 	bash build/nucleus/build.sh
 
 build-synapse-image:		## Builds synapse docker image
-	docker build -t ${SYNAPSE_IMAGE_NAME} --file $(SYNAPSE_DOCKER_FILE) .
+	docker build --build-arg VERSION=${VERSION}-dev -t ${SYNAPSE_IMAGE_NAME} --file $(SYNAPSE_DOCKER_FILE) .
 
 build-synapse-bin:			## Builds synapse binary
-	bash build/synapse/build.sh
+	bash build/synapse/build.sh

build/nucleus/Dockerfile

@@ -13,6 +13,10 @@ RUN GOARCH=amd64 GOOS=linux go build -ldflags="-w -s" -o nucleus cmd/nucleus/*.g
 
 # use a minimal alpine image
 FROM nikolaik/python-nodejs:python3.10-nodejs16-slim
+
+ARG VERSION
+ENV VERSION=$VERSION
+
 # Installing chromium so that all linux libs get automatically installed for running puppeteer tests
 RUN apt update && apt install -y git zstd chromium curl
 

build/synapse/Dockerfile

@@ -10,6 +10,9 @@ RUN go build -o synapse cmd/synapse/*.go
 # use a minimal alpine image
 FROM docker:latest
 
+ARG VERSION
+ENV VERSION=$VERSION
+
 # add ca-certificates in case you need them
 RUN apk update && apk add ca-certificates && rm -rf /var/cache/apk/*
 

cmd/nucleus/bin.go

@@ -44,7 +44,7 @@ func RootCommand() *cobra.Command {
 	rootCmd := cobra.Command{
 		Use:     "nucleus",
 		Long:    `nucleus is a coordinator binary used as entrypoint in tas containers`,
-		Version: global.NUCLEUS_BINARY_VERSION,
+		Version: global.NucleusBinaryVersion,
 		Run:     run,
 	}
 
@@ -160,7 +160,7 @@ func run(cmd *cobra.Command, args []string) {
 	pl.CacheStore = cache
 	pl.SecretParser = secretParser
 
-	logger.Infof("LambdaTest Nucleus version: %s", global.NUCLEUS_BINARY_VERSION)
+	logger.Infof("LambdaTest Nucleus version: %s", global.NucleusBinaryVersion)
 
 	wg.Add(1)
 	go func() {

cmd/synapse/bin.go

@@ -31,7 +31,7 @@ func RootCommand() *cobra.Command {
 	rootCmd := cobra.Command{
 		Use:     "synapse",
 		Long:    `Synapse is an opensource runner for TAS`,
-		Version: global.SYNAPSE_BINARY_VERSION,
+		Version: global.SynapseBinaryVersion,
 		Run:     run,
 	}
 

cmd/synapse/main.go

@@ -9,7 +9,7 @@ import (
 // Main function just executes root command `ts`
 // this project structure is inspired from `cobra` package
 func main() {
-	log.Printf("Starting synapse %s", global.SYNAPSE_BINARY_VERSION)
+	log.Printf("Starting synapse %s", global.SynapseBinaryVersion)
 	if err := RootCommand().Execute(); err != nil {
 		log.Fatal(err)
 	}

pkg/global/version.go

@@ -1,8 +1,10 @@
 package global
 
-const (
-	// NUCLEUS_BINARY_VERSION Nucleus version
-	NUCLEUS_BINARY_VERSION = "0.0.1"
-	// SYNAPSE_BINARY_VERSION Synapse version
-	SYNAPSE_BINARY_VERSION = "0.0.1"
+import "os"
+
+var (
+	// NucleusBinaryVersion Nucleus version
+	NucleusBinaryVersion = os.Getenv("VERSION")
+	// SynapseBinaryVersion Synapse version
+	SynapseBinaryVersion = os.Getenv("VERSION")
 )