Fixes

classes/manage.php

@@ -50,7 +50,7 @@ public static function add_instance($params) {
         $fields = $params['params'];
 
         // Verify the course.
-        $course = $DB->get_record('course', array('id'=>$fields['courseid']), '*', MUST_EXIST);
+        $course = $DB->get_record('course', ['id '=> $fields['courseid']], '*', MUST_EXIST);
 
         $plugin = enrol_get_plugin('manual');
 
@@ -62,4 +62,4 @@ public static function add_instance($params) {
         $enrolid = $plugin->add_instance($course, $fields);
         return $enrolid;
     }
-}
+}

db/services.php

@@ -25,7 +25,7 @@
 defined('MOODLE_INTERNAL') || die();
 
 $functions = [
-    'local_ws_enrol_manual_add_instance' =>  [
+    'local_ws_enrol_manual_add_instance' => [
         'classname' => 'local_ws_enrol_manual_external',
         'methodname' => 'add_instance',
         'classpath' => 'local/ws_enrol_manual/externallib.php',

externallib.php

@@ -22,8 +22,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-defined('MOODLE_INTERNAL') || die();
-
 use core_external\external_api;
 use core_external\external_function_parameters;
 use core_external\external_single_structure;
@@ -71,11 +69,16 @@ public static function add_instance($params) {
         ];
     }
 
+    /**
+     * Returns description of add_instance_returns() result value.
+     *
+     * @return \external_description
+     */
     public static function add_instance_returns() {
         return new external_single_structure(
             [
                 'id' => new external_value(PARAM_INT, 'id of the created instance')
-            ]        
+            ]
         );
     }
 }

version.php

@@ -26,4 +26,4 @@
 
 $plugin->version   = 2024120601;        // The current plugin version (Date: YYYYMMDDXX).
 $plugin->requires  = 2023100400;        // Requires this Moodle version.
-$plugin->component = 'local_ws_enrol_manual';  // Full name of the plugin (used for diagnostics).
+$plugin->component = 'local_ws_enrol_manual';  // Full name of the plugin (used for diagnostics).