Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immutable Components #190

Draft
wants to merge 5 commits into
base: 1.21
Choose a base branch
from
Draft

Immutable Components #190

wants to merge 5 commits into from

Conversation

williambl
Copy link

@williambl williambl commented Nov 18, 2024

wip...

  • methods on ImmutableComponentKey to get data / modify data without directly using the ImmutableComponentWrapper
  • support for attaching to things other than entities (lol)
  • support for registering custom ImmutableComponentCallbackTypes?
  • much cleaner code (it's written to work rn, not to be readable lol)
    • on that note, comments / javadoc...
      things which im not sure how im gonna fix them:
  • support for registering listeners from client side
  • NAMES !!
    • immutablecomponent is STUPID
      • datacomponent would be perfect but its ALREADY TAKEN by mojang
    • uhhh idk what to call these callback things like on tick, and you can tell because they're called like 3 different things in code
      • maybe ComponentHook or smth would be good
  • listeners/hooks/whatever are associated to a pair of (component ID, owner class) but this isn't uniquely identifiable of a component implementation (b/c of entity predicated factories and stuff)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant