Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test updates for Firefox 128 #962

Merged
merged 7 commits into from
Sep 16, 2024

Conversation

labkey-tchad
Copy link
Member

@labkey-tchad labkey-tchad commented Sep 12, 2024

Rationale

CustomizeView.clickViewGrid doesn't wait for the data region to update. applyCustomView should be used in most cases.

scrollIntoView doesn't seem to scroll svg points correctly, causing mouseOver to throw MoveTargetOutOfBoundsException when attempting to activate a tooltip.

org.openqa.selenium.interactions.MoveTargetOutOfBoundsException: Move target (366, 892) is out of bounds of viewport dimensions (1280, 891)
[...]
  at app//org.labkey.test.WebDriverWrapper.mouseOver(WebDriverWrapper.java:2943)
  at app//org.labkey.test.components.targetedms.QCPlotsWebPart.lambda$16(QCPlotsWebPart.java:434)
  at app//org.openqa.selenium.support.ui.FluentWait.until(FluentWait.java:203)
  at app//org.labkey.test.components.targetedms.QCPlotsWebPart.openExclusionBubble(QCPlotsWebPart.java:433)
  at app//org.labkey.test.tests.targetedms.TargetedMSQCTest.verifyExclusionButtonSelection(TargetedMSQCTest.java:974)
  at app//org.labkey.test.tests.targetedms.TargetedMSQCTest.testQCPlotExclusions(TargetedMSQCTest.java:858)

Related Pull Requests

  • N/A

Changes

  • Wait for data region update after adding columns
  • Scroll SVG point to the middle in openExclusionBubble

@labkey-tchad labkey-tchad requested review from a team and labkey-danield and removed request for a team September 12, 2024 16:58
@labkey-tchad labkey-tchad changed the title Wait for data region update after adding columns Test updates for Firefox 128 Sep 12, 2024
@labkey-tchad labkey-tchad requested review from labkey-sweta and removed request for labkey-danield September 13, 2024 19:39
@labkey-tchad labkey-tchad merged commit 6823282 into release24.7-SNAPSHOT Sep 16, 2024
5 checks passed
@labkey-tchad labkey-tchad deleted the 24.7_fb_applyCustomizeView branch September 16, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants