Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim down embedded dependencies #937

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Slim down embedded dependencies #937

merged 6 commits into from
Dec 3, 2024

Conversation

labkey-adam
Copy link
Contributor

@labkey-adam labkey-adam commented Nov 27, 2024

Rationale

Some dependencies in the embedded jar were included multiple times and others appear to be unnecessary. This removes 32 (~12MB) redundant, conflicting, or unneeded jars.

It's possible that one or more of these 32 jars is actually needed; @ankurjuneja may have more history here. I also plan to run BVTs and Dailies, and will merge after 24.12 branching to provide more bake time.

It's also possible we could eliminate a few more jars, but this PR seems like a good starting point.

Changes

  • Make tomcat-embed-core a dependency for bootstrap and stop pulling in redundant Tomcat dependencies there
  • Exclude spring-boot-starter-json: seems unused and pulls in an old version of Jackson
  • Exclude jakarta.annotation-api: already present in tomcat-annotations-api
  • Exclude tomcat-juli: already present in tomcat-embed-core
  • Remove spring-boot-starter-actuator: seems unused
  • Remove spring-boot-starter-validation: eliminating a single @NotNull annotation lets us remove this and its dependencies
  • Migrate a single use of org.jboss.logging.Logger (??) to log4j

@labkey-adam labkey-adam merged commit 0ad744c into develop Dec 3, 2024
4 checks passed
@labkey-adam labkey-adam deleted the fb_embedded_diet branch December 3, 2024 03:33
@labkey-adam labkey-adam mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants