Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GSON and JClouds #925

Closed
wants to merge 3 commits into from
Closed

Update GSON and JClouds #925

wants to merge 3 commits into from

Conversation

labkey-jeckels
Copy link
Contributor

@labkey-jeckels labkey-jeckels commented Nov 8, 2024

Rationale

We can move GSON forward now that we're using the newest JClouds release

Changes

  • Update GSON version

@labkey-adam
Copy link
Contributor

Need to force jakarta.ws.rs:jakarta.ws.rs-api and jakarta.annotation:jakarta.annotation-api?

Copy link
Contributor

@labkey-adam labkey-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the "joda-time" force line got duplicated. Maybe harmless, but probably good to get rid of it.

build.gradle Outdated
@@ -331,6 +335,7 @@ allprojects {

// Force consistency for dependencies from cloud
force "joda-time:joda-time:${jodaTimeVersion}"
force "joda-time:joda-time:${jodaTimeVersion}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. I was hacking at it in the hopes of eliminating the force, but it's still needed (only one though!)

@labkey-jeckels
Copy link
Contributor Author

Version 3.0.0 of jakarta.ws.rs:jakarta.ws.rs-api repackage from javax.->jakarta.. That makes it incompatible with the usage through the Docker module. Abandoning until the Docker dependency upgrades too.

@labkey-jeckels labkey-jeckels deleted the fb_s3Fix branch November 11, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants