Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test file templates #903

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Update test file templates #903

merged 2 commits into from
Oct 18, 2024

Conversation

labkey-tchad
Copy link
Member

@labkey-tchad labkey-tchad commented Oct 9, 2024 •
edited
Loading

Rationale

These test file templates generate files that contain warnings and errors by default.

Related Pull Requests

  • N/A

Changes

  • Update template user email to not cause an error when created
  • Add more specific generic types to example methods and element caches

@labkey-tchad labkey-tchad requested review from a team and labkey-chrisj and removed request for a team October 9, 2024 21:17
@labkey-tchad labkey-tchad merged commit e9da369 into develop Oct 18, 2024
6 checks passed
@labkey-tchad labkey-tchad deleted the fb_updateTestFileTemplates branch October 18, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-chrisj labkey-chrisj labkey-chrisj approved these changes

@labkey-danield labkey-danield labkey-danield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@labkey-tchad @labkey-danield @labkey-chrisj