Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating netty version to 4.1.100 in suppression for CVE-2023-4586 #607

Merged
merged 2 commits into from
Oct 26, 2023
Merged

updating netty version to 4.1.100 in suppression for CVE-2023-4586 #607

merged 2 commits into from
Oct 26, 2023

Conversation

labkey-willm
Copy link
Contributor

Rationale

updating netty version to 4.1.100 in suppression for CVE-2023-4586

Related Pull Requests

Changes

labkey-jeckels
labkey-jeckels requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OWASP check is still failing for all of the other Netty JARs that we pull in. I think need to adjust the packageUrl to catch more of them. I haven't tested, but something like ^pkg:maven/io\.netty/netty.*$ might do it

@labkey-willm
Copy link
Contributor Author

The OWASP check is still failing for all of the other Netty JARs that we pull in. I think need to adjust the packageUrl to catch more of them. I haven't tested, but something like ^pkg:maven/io\.netty/netty.*$ might do it

so changed. Sorry about the premature PR request. I saw all green on the tests but I guess the OWASP hadn't yet been added/run.

labkey-jeckels
labkey-jeckels approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@labkey-willm labkey-willm merged commit bd2c780 into release23.7-SNAPSHOT Oct 26, 2023
1 check passed
@labkey-willm labkey-willm deleted the 23.7_fb_netty-suppress-cve-report branch October 26, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-jeckels labkey-jeckels labkey-jeckels approved these changes

@labkey-adam labkey-adam Awaiting requested review from labkey-adam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-willm @labkey-jeckels