Merge pull request #205 from LabKey/fb_merge_24.7_to_develop

Merge discvr-24.7 to develop
LabKey · Aug 5, 2024 · aa6b28a · aa6b28a
2 parents 9764c1c + 3d630e2
commit aa6b28a
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/LDK/api-src/org/labkey/api/ldk/buttons/ShowEditUIButton.java b/LDK/api-src/org/labkey/api/ldk/buttons/ShowEditUIButton.java
@@ -38,11 +38,13 @@ public class ShowEditUIButton extends SimpleButtonConfigFactory
 
     protected Class<? extends Permission>[] _perms;
 
+    @SafeVarargs
     public ShowEditUIButton(Module owner, String schemaName, String queryName, Class<? extends Permission>... perms)
     {
         this(owner, schemaName, queryName, "Edit Records", perms);
     }
 
+    @SafeVarargs
     public ShowEditUIButton(Module owner, String schemaName, String queryName, String label, Class<? extends Permission>... perms)
     {
         super(owner, label, "");
@@ -87,20 +89,20 @@ protected String getJsHandler(TableInfo ti)
     {
         String schema = _schemaName == null || LDKService.ALL_SCHEMAS.equals(_schemaName) ? ti.getPublicSchemaName() : _schemaName;
         String query = _queryName == null || LDKService.ALL_TABLES.equalsIgnoreCase(_queryName) ? ti.getPublicName() : _queryName;
-        String ret = getHandlerName() + "(" + PageFlowUtil.jsString(schema) + "," + PageFlowUtil.jsString(query) + ",dataRegionName, {";
+        StringBuilder ret = new StringBuilder(getHandlerName() + "(" + PageFlowUtil.jsString(schema) + "," + PageFlowUtil.jsString(query) + ",dataRegionName, {");
 
         String delim = "";
         if (_urlParamMap != null)
         {
             for (String key : _urlParamMap.keySet())
             {
-                ret += delim + PageFlowUtil.jsString(key) + ":" + PageFlowUtil.jsString(_urlParamMap.get(key));
+                ret.append(delim).append(PageFlowUtil.jsString(key)).append(":").append(PageFlowUtil.jsString(_urlParamMap.get(key)));
                 delim = ",";
             }
         }
 
-        ret += "}, " + _copyFilters + ");";
+        ret.append("}, ").append(_copyFilters).append(");");
 
-        return ret;
+        return ret.toString();
     }
 }