Petites améliorations #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey !
61f0dc7: Dans deux fonctions, il y a les keywords virtual et override. Ca ne sert à rien de les mettre sur un même fonction, donc mieux vaut garder override (puisque le contract n'est pas hérité par un autre contract, donc le virtual est inutile).
d8ea869: Juste mis l'adresse en payable, pas super utile mais c'est toujours bon de l'ajouter.
9916d1c: Alors là je vous conseil de regarder le début de cette vidéo pour mieux comprendre comment fonctionne le storage sur Solidity. Ici, j'ai changé
_royaltyPartsPerMillionpar unuint24, puisque apparement sa valeur ne dépassera jamais 1 million (selon la fonctionsetRoyaltyPPM), donc inutile de mettre unuin256, ça prend un slot de storage entier alors qu'on peut aussi mettre le booléen_gaslessTradingdans ce même slot. Ca permet d'optimiser les gas.