Redecorate apps for all executors, to get task label in monitoring #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this PR, task names appeared in the monitoring database when uisng work queue executor because a run_command-like app was created for every invocation, and that app was customised to have the bps task label attached. With other executors, that code path was not used, and so other executors default to using the parsl default of name of the underlying Python function which in the gen3_workflow case was `run_command`. This PR switches to making a new app for every task invocation for all executor types, and applies the same task label modification. This makes the task label available in monitoring with all executor types.
benclifford
added a commit
to Parsl/parsl
that referenced
this pull request
Feb 7, 2024
…erns This follows some investigations of app names that turned out to be a bug in a different piece of code, resolved in LSSTDESC/gen3_workflow#58
benclifford
added a commit
to Parsl/parsl
that referenced
this pull request
Mar 18, 2024
…erns (#3056) This follows some investigations of app names that turned out to be a bug in a different piece of code, resolved in LSSTDESC/gen3_workflow#58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, task names appeared in the monitoring database when uisng work queue executor because a run_command-like app was created for every invocation, and that app was customised to have the bps task label attached.
With other executors, that code path was not used, and so other executors default to using the parsl default of name of the underlying Python function which in the gen3_workflow case was
run_command.This PR switches to making a new app for every task invocation for all executor types, and applies the same task label modification. This makes the task label available in monitoring with all executor types.