Add encryption to SACC file #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #58 Add encryption and decryption functionalities for SACC files. * **Encryption and Decryption**: - Add `generate_encryption_key`, `encrypt_data`, and `decrypt_data` methods in `src/smokescreen/datavector.py`. - Modify `save_concealed_datavector` method to encrypt the SACC file before saving. - Add `decrypt_sacc_file` function in `src/smokescreen/datavector.py`. * **Main Function**: - Update `main` function in `src/smokescreen/__main__.py` to handle encryption and decryption. - Add `decrypt`, `encrypted_file_path`, and `encryption_key_path` arguments to the `main` function. * **Tests**: - Add tests for `generate_encryption_key`, `encrypt_data`, and `decrypt_data` methods in `tests/test_datavector.py`. - Add tests for the modified `save_concealed_datavector` method. - Add tests for `decrypt_sacc_file` function. * **Documentation**: - Add a section in `docs/source/usage.rst` to document the encryption and decryption functionalities. * **Dependencies**: - Add `cryptography` as a dependency in `pyproject.toml` and `environment.yml`. Needs testing if the Fernet lib actually works with sacc! --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/LSSTDESC/Smokescreen/issues/58?shareId=XXXX-XXXX-XXXX-XXXX).
|
There are some unecessary files generated by the test with copilot spaces that should be removed before mergning |
|
pytest results: |
arthurmloureiro
added
data-vector blinding
|
Unsure if we can actually encrypt a fits file with this library. Maybe we need to encrypt the data instead. Needs further investigation. |
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #58
Add encryption and decryption functionalities for SACC files.
Encryption and Decryption:
generate_encryption_key,encrypt_data, anddecrypt_datamethods insrc/smokescreen/datavector.py.save_concealed_datavectormethod to encrypt the SACC file before saving.decrypt_sacc_filefunction insrc/smokescreen/datavector.py.Main Function:
mainfunction insrc/smokescreen/__main__.pyto handle encryption and decryption.decrypt,encrypted_file_path, andencryption_key_patharguments to themainfunction.Tests:
generate_encryption_key,encrypt_data, anddecrypt_datamethods intests/test_datavector.py.save_concealed_datavectormethod.decrypt_sacc_filefunction.Documentation:
docs/source/usage.rstto document the encryption and decryption functionalities.Dependencies:
cryptographyas a dependency inpyproject.tomlandenvironment.yml.Needs testing if the Fernet lib actually works with sacc!
For more details, open the Copilot Workspace session.