Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, I have an implementation of the schema for the spinner YAML configuration file. To make the implementation simpler, I made some changes to the current schema and I want opinions on this.
applications
. The problem with the current approach is that pydantic doesn't like arbitrary key names in YAML (e.g. the name of the application) mixed with fixed key names (e.g. description, version, runs, ...).Here is an example that is currently accepted by the implementation.
What do you guys think?
TODOs
Non-Trivial Validation
Benchmark parameters must exist in the command templateMisc
Migrate frompytest
tounittest