Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to Coq PR #19301 which unifies the syntax of Theorem, Definition and Fixpoint #703

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

herbelin
Copy link
Contributor

The change seems straightforward. I hope I did not break anything though.

To be merged synchronously with coq/coq#19301 when the latter is ready.

@gares
Copy link
Contributor

gares commented Oct 24, 2024

Coq-Elpi master supports two version of Coq (8.20 and master) at the same time thanks to ppx_optcomp.
You broke 8.20 since you did not add appropriate ifdefs.
See this PR for example: https://github.com/LPCIC/coq-elpi/pull/696/files

@herbelin herbelin force-pushed the master+adapt-coq-pr19301-ceps42-unify-definition-theorem branch from 5632f2f to d18bd37 Compare October 24, 2024 10:58
@herbelin
Copy link
Contributor Author

OK, I tried a new version. Since ifdef does not seem supported in coqpp code, I forced the anticipated parsing of binders already in 8.20 and it seems to work. Tell me if I should still do something.

@herbelin herbelin force-pushed the master+adapt-coq-pr19301-ceps42-unify-definition-theorem branch from d18bd37 to 92e0803 Compare October 24, 2024 11:14
@herbelin herbelin force-pushed the master+adapt-coq-pr19301-ceps42-unify-definition-theorem branch from 92e0803 to 429da2c Compare October 24, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants