Feat/force validation #603
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loeswerkman
commented
Jun 9, 2022
If values are empty after a successful call to VariantValidator, the onChange of these fields was originally removed to stop changes to these fields resulting in a complete reset. However, the complete reset has been removed with this branch, so the onChanges can be kept.
The original message was outdated since the onChange of the empty fields are no longer deactivated.
We now add checks to find out if all expected $_REQUEST variables were really set. If not, we will exit the script or set the values as empty.
ifokkema
requested changes
Jun 10, 2022
| // This field's variant was not fully validated! It should | ||
| // not be sent to the database. Let's add an error. | ||
| lovd_errorAdd($sField, | ||
| 'The variant ' . $sVariant . ' did not pass our checks. Please take another look and try again.' |
There was a problem hiding this comment.
The variable $sVariant isn't cleaned here, so shouldn't be sent out to the browser without cleaning (XSS vulnerability).
ifokkema
reviewed
Jun 10, 2022
ifokkema
reviewed
Jun 10, 2022
ifokkema
reviewed
Jun 10, 2022
From now on, we always remove the reference sequence from the variant that is saved in the $_SESSION['VV']['validated_variants'] array. Note that we then also need to ensure that reference sequences are not kept within the DNA fields!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this branch, the
$_SESSION['VV']['validated_variants']array is added and used to store all validated variants from the submission dialogue. This array is then used incheckFields()atPOSTto ensure that all variants in the submission form were indeed validated.Related to #588