Store the original variant description as the source of the submission #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifokkema
requested changes
Oct 5, 2021
There was a problem hiding this comment.
A few changes are needed; please see my comments (by accident in Dutch, but oh well). Could you take care of the needed changes?
Additionally, to actually test the code written in inc-upgrade.php and to be able to use this new field, you'll have to increase the version of the code to 3.5-pre-03 as well. You can do this in inc-init.php. Please make that change as well and add it to this branch.
Thanks!
loeswerkman
force-pushed
the
gb/sourceVariant
branch
from
cd4c8b4 to
49bf4a1
Compare
ifokkema
reviewed
Oct 5, 2021
src/variants.php
Outdated
| // Get the ID by its column suffix and give this as the source. | ||
| $sID = $_DB->query( | ||
| 'SELECT id FROM ' . TABLE_GENOME_BUILDS . | ||
| 'WHERE column_suffix = ?', array($sColumnSuffix))->fetchColumn(); |
There was a problem hiding this comment.
Not sure how this is possible, but there is another space missing. I thought we tested this code - this should have caused a query error. Anyway, I'll fix it.
- SQL is prettier and easier to read when aligned. - Since I already forgot an implementation detail, better document it.
8 tasks
ifokkema
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
sourcecolumn to the VOG table.Closes #560
Related to #550